Components: Upgrade react-virtualized to v9.4.0 #12628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice9js
added
[Status] Needs Review
|
@ice9js This PR needs a rebase |
samouri
force-pushed
the
update/react-virtualized
branch
from
451f896
to
e1de94a
Compare
matticbot
added
[Size] L
|
I rebased it, testing now |
samouri
force-pushed
the
update/react-virtualized
branch
from
e1de94a
to
035a79c
Compare
matticbot
added
[Size] S
|
rebased again! |
|
Everything LGTM! |
samouri
approved these changes
Apr 20, 2017
|
ccing people that have touched rv in Calypso: @youknowriad, @iseulde |
youknowriad
approved these changes
Apr 21, 2017
samouri
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests bumps the version of our
react-virtualizeddependency from8.8.1to9.4.0.A list of breaking changes introduced in 9.x can be found in the following pull request: bvaughn/react-virtualized#577.
For a complete list of changes, refer to the change log.
React version isn't a problem since we already use
15.4.0.I also didn't find any instance of
CellMeasurerin our codebase.Places to check: