-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Standardize store and module getters #1254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanethomas
added
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
[Feature Group] Emails & Domains
Features related to email integrations and domain management.
labels
Dec 3, 2015
stephanethomas
added
the
[Feature] Checkout
The checkout screen and process for purchases made on WordPress.com.
label
Dec 3, 2015
stephanethomas
force-pushed
the
fix/store-and-module-getters
branch
from
December 5, 2015 19:20
ecda755
to
c088ca9
Compare
gziolo
added
[Status] Ready to Merge
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Dec 7, 2015
Code changes look good and app works like before 👍 |
gziolo
added a commit
that referenced
this pull request
Dec 8, 2015
Domains: Standardize store and module getters
This was referenced Nov 18, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Checkout
The checkout screen and process for purchases made on WordPress.com.
[Feature Group] Emails & Domains
Features related to email integrations and domain management.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to standardize the few access methods that weren't following the de facto naming convention in Flux stores (used in the domains management section) as well as in a module (used in the checkout). The logic didn't change and everything should work as before.
Testing instructions
Checkout
Domains Search
pageAdd
button to add a domain to the shopping cartNo thanks, I don't need email or will use another provider.
link on the next pageDomain Registration Details
page that triggers the list of states (e.g. Spain)Secure Payment
page and check that the purchase was successfulDomains Management
Domains
pageDomain Settings
page