Jetpack: monthly plans test #11704
Merged
Jetpack: monthly plans test #11704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnHackworth
added
.org Plans
Jetpack
[Status] Needs Review
tyxla
approved these changes
Mar 2, 2017
There was a problem hiding this comment.
This tests well for me 👍
One minor thing that I've noticed: if you try to access /jetpack/connect/plans/monthly/$site with the test enabled (hideMonthly) for a free site, you will see reduced prices by 12 times, because it calculates the monthly price based on the yearly price / 12. This, however, will only happen if the user specifically visits this URL, because the monthly/yearly tabs are no longer visible (as expected).
tyxla
reviewed
Mar 2, 2017
client/lib/abtest/active-tests.js
Outdated
| showMonthy: 50, | ||
| hideMonthly: 50 | ||
| }, | ||
| defaultVariation: 'showMonthy', |
There was a problem hiding this comment.
We have a typo on various locations: showMonthy instead of showMonthly.
There was a problem hiding this comment.
damn autocomplete ... make the typo once, propagate it forever
…early one in the no-monthly side of the test
|
good catch @tyxla . I handled that case in a new commit |
matticbot
removed
the
[Status] Needs Review
johnHackworth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11607
TLDR: We are going to run an a/b test removing the jetpack monthly plans.
This PR implements it.
How to test:
0. First, go to http://calypso.localhost:3000/plans/ and select a jetpack site ... make sure everything looks right. Then connect that site and make sure everything works fine in the plans selection screen ( you will need a site without any purchased plan so you can see the plans step there)
Now let's start the test. Open the developer tools and run this in the console:
localStorage.setItem( 'ABTests', '{"jetpackPlansNoMonthly_20170302":"hideMonthly"}' );Go to http://calypso.localhost:3000/plans/ and select a jetpack site that doesn't have any paid plan. You should see something like this:
Disconnect that site and connect it again. In the plans selection step you should see:
Now purchase a plan with that site (or select any site with an already purchased plan). Go back to http://calypso.localhost:3000/plans/[site-slug]. This time, you should see the monthly plans selector:
Make sure you can see the monthly version of the plans
Now choose a WordPress.com site and go to the plans page again. Make sure nothing in this PR interfers with dotcom plans