Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages: show scheduled pages and fix empty placeholders #1158

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Dec 1, 2015

Fixes #452, to display scheduled pages.

Testing Instructions:

  1. Navigate to http://calypso.localhost:3000/page
  2. Add some content to the page editor
  3. Schedule the page to be published in the future by clicking on the calendar icon, selecting a future date, and clicking 'Schedule'
  4. Navigate to http://calypso.localhost:3000/pages
  5. Scheduled tab should be visible
  6. Clicking on the Scheduled tab should display your scheduled pages

Before:
screen shot 2015-12-01 at 11 31 59 am

After:
screen shot 2015-12-01 at 12 44 24 pm
screen shot 2015-12-01 at 12 44 44 pm

cc @alisterscott @rralian

@gwwar gwwar added Pages [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@rralian
Copy link
Contributor

rralian commented Dec 1, 2015

This looks good to me. The unfortunate thing is that /pages has not yet implemented post-counts and so statuses are not conditionally displayed. So scheduled will show up even when there are no scheduled pages. And scheduling pages is pretty uncommon.

But that's not the fault of this PR or something I think we should address here. Pages could use quite a bit of work all around. I think for now it makes sense to just address the reported issue as done here and then circle back at some point to finish implementing conditional statuses for pages.

That's a lot of words to say :shipit:. 😄

@rralian rralian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@alisterscott
Copy link
Contributor

Also tested this locally, looks good to me, besides always seeing scheduled which as mentioned will be another fix.
future pages

@gwwar
Copy link
Contributor Author

gwwar commented Dec 1, 2015

👍 Yup I noticed that, but it seemed way out of scope for this PR.

I've created #1168 so we can circle back to those enhancements.

gwwar added a commit that referenced this pull request Dec 1, 2015
Pages: show scheduled pages and fix empty placeholders
@gwwar gwwar merged commit 1c4d008 into master Dec 1, 2015
@gwwar gwwar deleted the fix/show-scheduled-pages-452 branch December 1, 2015 23:56
@gwwar gwwar added this to the Core: Iteration 17 milestone Dec 4, 2015
@gwwar gwwar self-assigned this Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants