Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video: Add support for selecting or uploading a custom image to serve as the video poster #11389

Closed
wants to merge 51 commits into from
Closed

Video: Add support for selecting or uploading a custom image to serve as the video poster #11389

wants to merge 51 commits into from

Conversation

donnapep
Copy link
Contributor

@donnapep donnapep commented Feb 14, 2017 •
edited
Loading

This PR adds a VideoEditor block, which enables choosing a custom VideoPress poster by either selecting a particular frame of the video or by uploading a custom image.

Testing

You will need to test using a non-Jetpack site with VideoPress enabled until support is added for Jetpack sites as well.

The Video Editor can be accessed in the editor by selecting "Add Media" from the toolbar dropdown, selecting a video, clicking the "Edit" button, and then clicking the "Edit Thumbnail" button:

screen shot 2017-02-15 at 11 42 15 am

screen shot 2017-02-15 at 11 37 29 am

If the video cannot be loaded or an error occurs when updating the poster, the following message is shown:

screen shot 2017-02-15 at 11 38 09 am

This PR is the master but has been split out into separate PRs (#11633, #11637, #11648, #11653)

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/video-thumbnail-picker

@donnapep donnapep self-assigned this Feb 14, 2017
a8ci18n
a8ci18n reviewed Feb 14, 2017
View reviewed changes
client/blocks/video-editor/video-editor-buttons.jsx Outdated
primary
onClick={ onSelectFrame }
>
{ translate( 'Select Frame' ) }
Copy link

@a8ci18n a8ci18n Feb 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 28 times:
translate( 'Frames' ) ES Score: 7.80

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

a8ci18n
a8ci18n reviewed Feb 14, 2017
View reviewed changes
client/post-editor/media-modal/detail/detail-item.jsx
let editText = translate( 'Edit Image' );

if ( 'video' === mimePrefix ) {
editText = translate( 'Edit Thumbnail' );
Copy link

@a8ci18n a8ci18n Feb 14, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 79 times:
translate( 'Thumbnail' ) ES Score: 7

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

@donnapep donnapep force-pushed the add/video-thumbnail-picker branch 8 times, most recently from 720d9e8 to cf721d3 Compare February 15, 2017 12:51
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 21, 2017
@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from 8160337 to 25e740b Compare February 21, 2017 16:51
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 21, 2017
a8ci18n
a8ci18n reviewed Feb 21, 2017
View reviewed changes
client/blocks/video-editor/video-editor-buttons.jsx Outdated
disabled={ ! isVideoLoaded }
onClick={ onSelectFrame }
primary>
{ translate( 'Select Frame' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 28 times:
translate( 'Frames' ) ES Score: 7.80

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from 029efa5 to 5548686 Compare February 22, 2017 14:48
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 22, 2017
@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from 90d5bb9 to e9bd4de Compare February 22, 2017 15:31
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 22, 2017
@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from 37c5ea7 to 4f95bf8 Compare February 22, 2017 15:59
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 22, 2017
@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from bbdab26 to ee0c999 Compare February 22, 2017 16:07
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 22, 2017
@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from ee0c999 to 1baf577 Compare February 22, 2017 16:15
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 22, 2017
@donnapep donnapep added [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 23, 2017
@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Feb 24, 2017
donnapep added 15 commits June 9, 2017 08:57
@donnapep
Fix poster thumbnail not updating
ce25cd4
@donnapep
Fix video editor not working in Media Library
bd16915
@donnapep
Add upload progress to Redux state and remove video loading and scrip…
40c4237 
…t errors
@donnapep
Show progress bar instead of spinner when uploading image
e146dcc
@donnapep
Fix issue with error not showing when poster could not be updated
cb76c0c
@donnapep
Rename poster upload progress action
48f8658
@donnapep
Remove obsolete action for resetting poster state
0c8de21
@donnapep
Rename Redux update actions
a8533b8
@donnapep
Rename upload progress action creator
47d0514
@donnapep
Alter conditions under which video is considered loaded
86d4c99
@donnapep
Change location of progress bar component
7692c2a
@donnapep
Move selectors and tests to state/selectors
5617a5d
@donnapep
Use 'atTime' instead of 'at_time'
111b7d3
@donnapep
Fix thumbnail not updating in Media Library
93ac3a7
@donnapep
Refactor actions
4dbc3c3
@donnapep donnapep force-pushed the add/video-thumbnail-picker branch from 8ece840 to 4dbc3c3 Compare June 9, 2017 13:38
@donnapep
Copy link
Contributor Author

This was the master PR for video editor, but it has since been separated out into multiple PRs.

@donnapep donnapep closed this Jun 13, 2017
@donnapep donnapep deleted the add/video-thumbnail-picker branch June 13, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8ci18n a8ci18n a8ci18n left review comments

@roccotripaldi roccotripaldi roccotripaldi left review comments

Assignees

@donnapep donnapep

Labels
[Size] XL Probably needs to be broken down into multiple smaller issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@donnapep @matticbot @beaulebens @dbtlr @roccotripaldi @a8ci18n