Repository navigation
ui: Stepper CSS cleanups from #111036 review feedback - #111616
Merged
Merged
Conversation
…e tokens Follow-up to review feedback on #111036: - The base `.title` color never applied; it is always overridden by the higher-specificity `[data-indicator-variant] .title` rules since the root always renders `data-indicator-variant`. - Replace the magic `margin: 1px` on bullet indicators with a calc() derived from the indicator size variables, so the centre alignment stays correct if the sizes ever change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
|
3 of 10 tasks
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
Looks like one of the E2E tests has failed. You can fix them following these steps:
|
bogiii
marked this pull request as ready for review
June 12, 2026 11:46
5 of 12 tasks
ciampo
approved these changes
Jun 15, 2026
ciampo
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀
Left an optional comment, feel free to address it and merge without the need for another round of review 👍
Replace the duplicated margin calc on current/completed bullet indicators with a single --a8c-ui-stepper-indicator-offset token. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the follow-up work for the Stepper review feedback in #111036.
Proposed Changes
colordeclaration from the base.titlerule. It never applied: the stepper root always rendersdata-indicator-variant, so the higher-specificity[data-indicator-variant] .titlerules always win. Addresses this comment.margin: 1pxon the bullet indicator variant (current and completed states) withcalc( ( var( --a8c-ui-stepper-indicator-size ) - var( --a8c-ui-stepper-indicator-size-sm ) ) * 0.5 ), so the centre-alignment compensation is derived from the size variables instead of a hardcoded number. Addresses this comment.Why are these changes being made?
Testing Instructions
VerticalStepperandHorizontalStepperwith thebulletindicator variant.1px:(18px - 16px) / 2).Pre-merge Checklist