Skip to content

Omnibar: Fix Help Center icon size - #111339

Merged
fushar merged 1 commit into
trunkfrom
fix-omnibar-help-center
Jun 4, 2026
Merged

fushar merged 1 commit into
trunkfrom
fix-omnibar-help-center

Conversation

@fushar

@fushar fushar commented Jun 4, 2026 •

Copy link
Copy Markdown
Contributor

Fixes p1780036567190559-slack-CRWCHQGUB

Proposed Changes

Fix the help center icon size to match wp-admin's:

Before After
image image
Before After
image image

Why are these changes being made?

Fixes a regression. I think this was introduced some time when we upgrade our dependencies, maybe @wordpress/components.

Testing Instructions

Check the help center icon size on /sites on desktop and mobile resolutions.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • For UI changes, have you tested the affected components in dark mode?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@fushar
fushar requested a review from a team June 4, 2026 04:35
@fushar fushar self-assigned this Jun 4, 2026
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 4, 2026
@fushar
fushar marked this pull request as ready for review June 4, 2026 04:35
@matticbot

Copy link
Copy Markdown
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix-omnibar-help-center on your sandbox.

@StevenDufresne

Copy link
Copy Markdown
Contributor

Visually this looks better, but this will make the button size larger than the bell. Can we increase the size of the svg paths themselves?

@p-jackson

Copy link
Copy Markdown
Member

I think this was introduced some time when we upgrade our dependencies, maybe @wordpress/components.

@wordpress/icons was upgraded in #111123, so probably that package.

Fwiw the help icon doesn't look bigger than the bell to me. And comparing it to the size of the (w) (which is the other circle we can compare to) it looks about right. IMO.

This is broken in the non-interim omnibar too. So if you were feeling very generous you could fix in Calypso v1 too :)

@fushar
fushar merged commit 980fbae into trunk Jun 4, 2026
17 checks passed
@fushar
fushar deleted the fix-omnibar-help-center branch June 4, 2026 06:28
@github-actions github-actions Bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 4, 2026
@fushar

fushar commented Jun 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Whoops clicked merge without realizing that there are comments 😓

but this will make the button size larger than the bell.

I am using wp-admin as reference. Calypso's and wp-admin's have the exact same size now:

image



This is broken in the non-interim omnibar too. So if you were feeling very generous you could fix in Calypso v1 too :)

It should fix v1 as well. We're using the same component 😄

@StevenDufresne

Copy link
Copy Markdown
Contributor

Fwiw the help icon doesn't look bigger than the bell to me.

Screenshot 2026-06-05 at 10 47 29 AM

I am speaking about the target size of the wrapping element. It's not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants