Skip to content

Dashboard: pass onReset to DataViews as it's now supported upstream - #111037

Merged
arthur791004 merged 1 commit into
trunkfrom
move-reset-view
May 27, 2026
Merged

arthur791004 merged 1 commit into
trunkfrom
move-reset-view

Conversation

@fushar

@fushar fushar commented May 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes DOTMSD-1096

Proposed Changes

Use DataViews' native onReset introduced in WordPress/gutenberg#75093, instead of using our own custom one.

Before After
image image

Why are these changes being made?

Core-first design.

Testing Instructions

  1. Go to /sites
  2. Try modifying the DataViews appearances using the top-right gear icon
  3. Verify it shows a blue dot and when clicked you see the Reset view button as screenshot above.
  4. Smoke-test other DataViews in other pages in MSD.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • For UI changes, have you tested the affected components in dark mode?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot

Copy link
Copy Markdown
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug move-reset-view on your sandbox.

@fushar
fushar marked this pull request as ready for review May 26, 2026 09:52
@fushar
fushar requested review from a team as code owners May 26, 2026 09:52
@fushar fushar self-assigned this May 26, 2026
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 26, 2026

@arthur791004 arthur791004 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@arthur791004
arthur791004 merged commit 26763d7 into trunk May 27, 2026
23 checks passed
@arthur791004
arthur791004 deleted the move-reset-view branch May 27, 2026 05:53
@github-actions github-actions Bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants