Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS: OnBoarding: welcome an wait terminal messages #1039

Merged
merged 3 commits into from
Nov 30, 2015
Merged

OSS: OnBoarding: welcome an wait terminal messages #1039

merged 3 commits into from
Nov 30, 2015

Conversation

folletto
Copy link
Contributor

Partially addressing #1034.

Specifically fixes:

  • Terminal: No startup message. Not a big deal, but would be nice to show something.
  • Terminal: No wait message. This is rather important since in the test it was causing some confusion.

These are the things this PR adds / changes:

screen shot 2015-11-30 at 15 02 30

screen shot 2015-11-30 at 15 11 16

screen shot 2015-11-30 at 15 11 33

To test:

  • make run
  • Check that the initial message, instantly after run, is there
  • Check the wait message once the server is ready.
  • Check the ready message once done.

@folletto folletto added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. OSS labels Nov 30, 2015
@folletto folletto self-assigned this Nov 30, 2015
@mtias
Copy link
Member

mtias commented Nov 30, 2015

Looks good to me!

@mtias mtias added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 30, 2015
folletto added a commit that referenced this pull request Nov 30, 2015
@folletto
Merge pull request #1039 from Automattic/update/onboarding-terminal-w…
12baf71 
…elcome

OSS: OnBoarding: welcome an wait terminal messages
@folletto folletto merged commit 12baf71 into master Nov 30, 2015
@folletto folletto deleted the update/onboarding-terminal-welcome branch November 30, 2015 15:20
@folletto folletto mentioned this pull request Nov 30, 2015
Closed
@folletto folletto mentioned this pull request Dec 11, 2015
Closed
@ciprianimike ciprianimike mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@folletto folletto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folletto @mtias @scruffian