Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosted Site Migration: DYF Instructions is not showing direct links to the plugin installation #98682

Closed
gabrielcaires opened this issue Jan 21, 2025 · 3 comments · Fixed by #98938 or #99129
Closed

Hosted Site Migration: DYF Instructions is not showing direct links to the plugin installation #98682

gabrielcaires opened this issue Jan 21, 2025 · 3 comments · Fixed by #98938 or #99129
Assignees
@sixhours
Labels
[Experiment] AI labels added [Feature Group] Site Migration [Feature] Plugin Management [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Feature] Site Migration Features related to site migrations to WPcom [Pri] High Address as soon as possible after BLOCKER issues [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@gabrielcaires
Copy link
Contributor

Context and steps to reproduce

In some use cases, the "Install plugin" button on the migration instructions page does not directly show the plugin installation link.

Image

  1. Start the /setup/hosted-site-migration.
  2. Set a WordPress site on the identify step
  3. Create a new site on the Pick your destination
  4. Follow all steps related to DYF path
  5. Check the install link is not pointing to the direct link, which installs a plugin.

Tech Details

The instructions step uses the from query param to build the link; we are losing these parameters during the flow.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Critical

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform

No response
@gabrielcaires gabrielcaires added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 21, 2025
@markbiek markbiek added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Jan 21, 2025
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 21, 2025
@github-actions github-actions bot added [Pri] High Address as soon as possible after BLOCKER issues [Feature Group] Site Migration [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Feature] Plugin Management labels Jan 21, 2025
@github-actions GitHub Actions
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Site Migration: The issue relates directly to the migration process of hosted sites, emphasizing the importance of installation links during this flow.
  • [Feature] Plugins: The problem specifically involves the installation link for plugins, indicating that this issue impacts plugin management.
  • [Feature] Plugin Management: This label is relevant because the problem is centered around managing and directing users to install a specific plugin through the migration instructions.

@markbiek markbiek added the [Feature] Site Migration Features related to site migrations to WPcom label Jan 29, 2025
@matticbot matticbot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jan 29, 2025
@sixhours sixhours self-assigned this Jan 29, 2025
@sixhours
Copy link
Contributor

I think this should be fixed by #98938 as this also passes the from param through to the instructions step so we can send it to the Atomic transfer API and set a site option with the source site.

@sixhours sixhours mentioned this issue Jan 30, 2025
Merged
8 tasks
@sixhours sixhours mentioned this issue Jan 30, 2025
Merged
8 tasks
@sixhours sixhours reopened this Jan 30, 2025
@matticbot matticbot moved this from Done 🎉 to Triaged in Automattic Prioritization: The One Board ™ Jan 30, 2025
@sixhours
Copy link
Contributor

Had to revert the original PR due to test failures (that were not caused by the PR, but better safe than sorry). Reopening until the new PR gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sixhours sixhours

Labels
[Experiment] AI labels added [Feature Group] Site Migration [Feature] Plugin Management [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Feature] Site Migration Features related to site migrations to WPcom [Pri] High Address as soon as possible after BLOCKER issues [Status] Auto-allocated [Status] Escalated to Product Ambassadors [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Status: Done 🎉
Milestone
No milestone
4 participants
@gabrielcaires @markbiek @sixhours @matticbot