Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to change their minds about Big Sky on the plans page #99128

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented Jan 30, 2025

Related to #99085

Proposed Changes

Plan page Header changes

  • Big Sky + paid/free domain, the plans page shows a custom subtitle text:

image

  • No Big Sky + paid domain = Current behavior:

image

  • No Big Sky + free domain = Current behavior:

image

Modal changes

  • Big sky + free domain + Start with a free plan: Will show this modal:

CleanShot 2025-01-31 at 16 17 01@2x

  • Big sky + paid domain + Start with a free plan: Will show this modal:

CleanShot 2025-01-31 at 16 17 51@2x

  • No Big sky + paid domain = current behavior (title + subtitle):

image

Testing Instructions

  1. Select the Big Sky option
  2. Select a paid domain
  3. Check that on the plans page, we have a custom subtitle for Big Sky
  4. Click con Start with a free plan
  5. Check that we have a custom modal title
  6. Click on Continue with a free plan
  7. Make sure the user goes to launchpad instead of checkout/Big Sky and has a free plan
Screen.Recording.2025-01-30.at.16.30.12.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 requested a review from a team January 30, 2025 19:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2025
@paulopmt1 paulopmt1 linked an issue Jan 30, 2025 that may be closed by this pull request
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~10 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +99 B  (+0.0%)      +10 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~14038 bytes added 📈 [gzipped])

name                             parsed_size            gzip_size
jetpack-app                         +47671 B  (+11.2%)   +13264 B  (+9.6%)
plugins                             +46638 B   (+1.4%)   +12941 B  (+1.4%)
plans                               +45296 B   (+3.3%)   +12373 B  (+3.0%)
update-design-flow                    +739 B   (+0.0%)     +192 B  (+0.0%)
link-in-bio-tld-flow                  +739 B   (+0.0%)     +192 B  (+0.0%)
jetpack-cloud-plugin-management        -13 B   (-0.0%)      -11 B  (-0.0%)
a8c-for-agencies-plugins               -13 B   (-0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~192 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       +739 B  (+0.2%)     +192 B  (+0.1%)
async-load-signup-steps-plans                         +739 B  (+0.2%)     +192 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should show the Start with free regardless of if they choose a paid domain or not? BigSky is a paid feature so we give them the same free escape hatch even if the selected a free domain.

Currently if i select a free domain, I don't get the escape hatch

image

@paulopmt1
Copy link
Contributor Author

I wonder if we should show the Start with free regardless of if they choose a paid domain or not
Currently if i select a free domain, I don't get the escape hatch

That makes sense! I'll investigate how to do that.

@paulopmt1
Copy link
Contributor Author

We'll still have one more variation. Context: p1738269257951999/1738217832.782999-slack-C085HCWCEDN

@paulopmt1 paulopmt1 requested a review from vykes-mac January 30, 2025 21:26
@paulopmt1 paulopmt1 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 30, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 30, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220109

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators.

@p-jackson p-jackson force-pushed the update/allow-users-change-their-minds-about-big-sky branch from e8bfedf to 34d7c76 Compare January 31, 2025 01:56
@autumnfjeld
Copy link
Contributor

@isatuncman-auto @fditrapani The free plan modals are in this PR.

paulopmt1 and others added 4 commits January 31, 2025 16:05
…IS_REQUIRED_DIALOG

Changes needed to be made to the useModalResolutionCallback hook anyway
to ensure the dialog appeared when the user had a free domain.

So switching to the PAID_PLAN_IS_REQUIRED_DIALOG dialog was better for
us anyway, since it doesn't include the green "free for a year" text
that sometimes appears.
@p-jackson p-jackson force-pushed the update/allow-users-change-their-minds-about-big-sky branch from f51f817 to 0f84a69 Compare January 31, 2025 03:11
@p-jackson p-jackson requested review from a team as code owners January 31, 2025 03:11
@p-jackson p-jackson changed the base branch from add/experiment-to-big-sky to trunk January 31, 2025 03:12
@p-jackson
Copy link
Member

This PR doesn't include any feature flag or experiment assignment checks, so I was able to rebase onto trunk

@p-jackson p-jackson merged commit a38e4b1 into trunk Jan 31, 2025
14 of 15 checks passed
@p-jackson p-jackson deleted the update/allow-users-change-their-minds-about-big-sky branch January 31, 2025 03:24
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jan 31, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 31, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17220109

Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 3, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Update "Free plan modals" to allow backing out of Big Sky
6 participants