Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Picker: searching should support arrow keys + enter #8

Closed
alisterscott opened this issue Nov 17, 2015 · 4 comments · Fixed by #5808
Closed

Site Picker: searching should support arrow keys + enter #8

alisterscott opened this issue Nov 17, 2015 · 4 comments · Fixed by #5808
Assignees
@marekhrabe
Labels
Site Picker [Type] Enhancement

Comments

@alisterscott
Copy link
Contributor

The flow would be something like:

  1. Select switch site
  2. it should focus in the search field
  3. type "my"
  4. list is immediately filtered down to sites containing the string "my", with the top site in the list being auto-selected and visibly highlighted (same as the hover effect we currently have)
  5. I actually want the second site in the list, so I can just hit the down arrow on my keyboard, which would move the highlight/active selection down to the second site in the list (my cursor is still in the search field though, so I could keep typing if I want)
  6. I can now hit enter to select the second site in the list, since that's where my highlight/selection is.

It would work very similar as github @mentions
@mtias mtias mentioned this issue Jan 8, 2016
Closed
@ryanboren
Copy link
Contributor

https://test.wordpress.com/2016/01/15/keyboard-nav-in-the-site-selectors/

@beaulebens
Copy link
Member

This should ideally work the same when you click the "New Post" button in the masterbar/toolbar. Click, type, arrows, hit enter.

@marekhrabe marekhrabe self-assigned this May 28, 2016
@alisterscott
Copy link
Contributor Author

Confirmed that searching immediately works, but the up/down and return keys don't, so leaving this open for now

@marekhrabe marekhrabe mentioned this issue Jun 11, 2016
Merged
@marekhrabe
Copy link
Contributor

marekhrabe commented Jun 11, 2016 •
edited
Loading

PR is ready to be tested #5808

@stephanethomas stephanethomas mentioned this issue Jul 7, 2017
Merged
3 tasks
sirreal pushed a commit that referenced this issue Dec 5, 2018
@deBhal @sirreal
Merge pull request #8 from Automattic/add/redux-no-bound-selectors
5fbe898 
Add wpcalypso/redux-no-bound-selectors rule as error
sirreal pushed a commit that referenced this issue Dec 5, 2018
@aduth @sirreal
Merge pull request #8 from Automattic/add/check-gridicon-format
be4aea2 
Add rule `jsx-gridicon-size` for enforcing recommended Gridicon size
sirreal added a commit that referenced this issue Dec 5, 2018
@sirreal
Update travis Node versions (#8)
6ccb3d0 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal pushed a commit that referenced this issue Dec 5, 2018
@deBhal @sirreal
Merge pull request #8 from Automattic/add/redux-no-bound-selectors
8eed190 
Add wpcalypso/redux-no-bound-selectors rule as error
sirreal pushed a commit that referenced this issue Dec 5, 2018
@aduth @sirreal
Merge pull request #8 from Automattic/add/check-gridicon-format
de5310d 
Add rule `jsx-gridicon-size` for enforcing recommended Gridicon size
sirreal added a commit that referenced this issue Dec 5, 2018
@sirreal
Update travis Node versions (#8)
88a6c49 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal pushed a commit that referenced this issue Dec 6, 2018
@deBhal @sirreal
Merge pull request #8 from Automattic/add/redux-no-bound-selectors
bf760d0 
Add wpcalypso/redux-no-bound-selectors rule as error
sirreal pushed a commit that referenced this issue Dec 6, 2018
@aduth @sirreal
Merge pull request #8 from Automattic/add/check-gridicon-format
630e93c 
Add rule `jsx-gridicon-size` for enforcing recommended Gridicon size
sirreal added a commit that referenced this issue Dec 6, 2018
@sirreal
Update travis Node versions (#8)
ee48ad5 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
blowery pushed a commit that referenced this issue Dec 7, 2018
@sirreal @blowery
Update travis Node versions (#8)
2dbf077 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal added a commit that referenced this issue Dec 11, 2018
@sirreal
Update travis Node versions (#8)
b2a31a6 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal pushed a commit that referenced this issue Dec 11, 2018
@deBhal @sirreal
Merge pull request #8 from Automattic/add/redux-no-bound-selectors
58e6f20 
Add wpcalypso/redux-no-bound-selectors rule as error
sirreal pushed a commit that referenced this issue Dec 11, 2018
@aduth @sirreal
Merge pull request #8 from Automattic/add/check-gridicon-format
3d37812 
Add rule `jsx-gridicon-size` for enforcing recommended Gridicon size
sirreal added a commit that referenced this issue Dec 20, 2018
@sirreal
Update travis Node versions (#8)
edaab01 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal added a commit that referenced this issue Jan 7, 2019
@sirreal
Update travis Node versions (#8)
2949a1c 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal added a commit that referenced this issue Jan 11, 2019
@sirreal
Update travis Node versions (#8)
0ecd3ab 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
blowery pushed a commit that referenced this issue Feb 19, 2019
@sirreal @blowery
Update travis Node versions (#8)
a558bc4 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
sirreal added a commit that referenced this issue Feb 20, 2019
@sirreal
Update travis Node versions (#8)
86a6b58 
* Update node/npm test versions

* Clean up Travis config

* Update package-lock for node@10 and [email protected]
@obenland obenland mentioned this issue May 23, 2019
Closed
sirreal pushed a commit that referenced this issue Oct 10, 2019
@sgomes @sirreal
Merge pull request #8 from Automattic/add/remove-create-reducer
8768290 
Add codemod to remove create-reducer
sirreal pushed a commit that referenced this issue Oct 11, 2019
@sgomes @sirreal
Merge pull request #8 from Automattic/add/remove-create-reducer
00f50b6 
Add codemod to remove create-reducer
sirreal pushed a commit that referenced this issue Oct 16, 2019
@sgomes @sirreal
Merge pull request #8 from Automattic/add/remove-create-reducer
3b5112d 
Add codemod to remove create-reducer
sirreal pushed a commit that referenced this issue Nov 14, 2019
@sgomes @sirreal
Merge pull request #8 from Automattic/add/remove-create-reducer
69b805e 
Add codemod to remove create-reducer
sirreal added a commit that referenced this issue Nov 14, 2019
@sirreal
Calypso Codemods: Pull in to monorepo (#36645)
8037766 
* first commit

* copy files from wp-calypso

* Run script + setup test harness

* Make index.js a binary

* add travis config and tweak README

* add section to readme explaining how to add new tests

* prettify + remove all references to config

* add tests: merge-lodash-imports

* tests: add modular-lodash-no-more

* tests: add combine-reducer-with-persistence

* tests: add combine-state-utils-imports

* tests: add i18n-mixin-to-localize

* tests: add modular-lodash-requires-no-more

* i18n-mixin-to-localize: must use dbl quotes

* bump package for release

* Fix build for npm

* should be able to run from anywhere

* fix broken deps so tests can pass. do not use yarn

* no yarn

* add single tree rendering

* Update dependencies to latests versions (#4)

* Update dependencies to latests versions

Updated deps, hopefully to get rid of GitHub's security warnings about `hoek`.
The update also updated `package.json` to NPM 6 format.

* Tell Travis CI to use Node 10

* Fix codemod name in documentation (#5)

* Merge pull request #8 from Automattic/add/remove-create-reducer

Add codemod to remove create-reducer

* Prep for calypso

* npm install
jsnajdr pushed a commit that referenced this issue Jan 27, 2020
@retrofox @jsnajdr
Merge pull request #8 from Automattic/update/name-doc
3c631b7 
Update/name doc
@stephanethomas stephanethomas mentioned this issue Dec 7, 2021
Merged
@pauloeaquino pauloeaquino mentioned this issue Mar 3, 2022
Closed
@gcsecsey gcsecsey mentioned this issue Jan 12, 2023
Closed
@matticbot matticbot mentioned this issue Oct 11, 2023
Merged
1 task
gabrielcaires added a commit that referenced this issue Feb 7, 2024
@gabrielcaires
Revert "Revert "Revert "Revert "Launchpad: Clean up task-helper (#86960…
ed3238d 
…)" (#8…"

This reverts commit 06054dd.
@matticbot matticbot mentioned this issue Jun 21, 2024
Open
1 task
@chihsuan chihsuan mentioned this issue Nov 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marekhrabe marekhrabe

Labels
Site Picker [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keyboard controls for SiteSelector Automattic/wp-calypso
4 participants
@beaulebens @alisterscott @marekhrabe @ryanboren