Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevDocs: Add filter to gridicons section #460

Closed
alisterscott opened this issue Nov 23, 2015 · 7 comments
Closed

DevDocs: Add filter to gridicons section #460

alisterscott opened this issue Nov 23, 2015 · 7 comments
Labels
DevDocs [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@alisterscott
Copy link
Contributor

Originally raised by @kellychoffman:

It would be nice if we could add a way to search/filter the gridicons list in the Dev Docs

@alisterscott alisterscott added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it DevDocs labels Nov 23, 2015
@afsheenirani
Copy link
Contributor

@alisterscott / @kellychoffman - That is a great point. Currently the UI components page seems to apply filtering to only the titles/headings for the various components and further granularity is not available. Let me take a stab at this enhancement.

What i'm thinking at a high-level is that the filtering should apply to even the text that helps define the UI component.

So for an example Gridicon: <Gridicon icon="link" /> we should be able to filter on link.

Thoughts?

cc @nb for fyi.

@kellychoffman
Copy link
Member

It would be cool if you could search using the search bar at the top of https://wpcalypso.wordpress.com/devdocs/design/, but that isn't available on the gridicon page itself, if you have it bookmarked: https://wpcalypso.wordpress.com/devdocs/design/gridicons.

@afsheenirani
Copy link
Contributor

@kellychoffman - Hahaha...there's no way you can get to that gridicons link from the main Sidebar or through links on the ui-components page...so I guess you can only play with the url paths or would have to know the folder structure in order to get to it.

I see your point though, let me think of this some more to see if this can be "generalized" some way. So that even "Social Logos" can have a search (or for that matter any "groupings" of components):
https://wpcalypso.wordpress.com/devdocs/design/sociallogos

@kellychoffman
Copy link
Member

there's no way you can get to that gridicons link from the main Sidebar or through links on the ui-components page

You can get to it by clicking on the Gridicons heading from the main page. All the headers are links. I constantly referred to the /gridicons page when working on new features.

@afsheenirani
Copy link
Contributor

Ah! my bad...

@kellychoffman
Copy link
Member

No worries - I should have specified in my previous comment.

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevDocs [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants