Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Gridicons\SocialLogos - How are index.jsx files for gridicon and social-logo generated? #3634

Closed
afsheenirani opened this issue Feb 28, 2016 · 8 comments

Comments

@afsheenirani
Copy link
Contributor

Steps to reproduce

In the gridicon and social-logo component definitions it says that those files are auto-generated and should not be manually updated.

  • wp-calypso/client/components/gridicon/index.jsx
  • wp-calypso/client/components/social-logo/index.jsx

/* !!! IF YOU ARE EDITING gridicon/index.jsx THEN YOU ARE EDITING A FILE THAT GETS OUTPUT FROM THE GRIDICONS REPO! DO NOT EDIT THAT FILE! EDIT index-header.jsx and index-footer.jsx instead OR if you're looking to change now SVGs get output, you'll need to edit strings in the Gruntfile :) !!! */

As part of #460 I am looking to introduce search/filter capability for Gridicons and SocialLogos and wanted to better understand this bit...

What I expected

I expected to search on the entire codebase for either one of the following three keywords to produce some results in order that I could inspect the logic of how these are generated.

  1. index-header.jsx
  2. index-footer.jsx
  3. Gruntfile

What happened instead

My search turned up no results.

Browser / OS version

N/A

Screenshot / Video

N/A

Subject Matter Experts

@apeatling @ehg @jasmussen @nb @alternatekev @mcsf @ockham @seear

@folletto
Copy link
Contributor

We have a separate repo to manage that, and we still hadn't open sourced yet properly tho. Thanks for raising the question — we'll update here once it's done. :)

@afsheenirani
Copy link
Contributor Author

@folletto - Thanks for the update...will watch out for any updates to this thread then. Cheers!

@folletto
Copy link
Contributor

folletto commented Mar 1, 2016

The Gridicons repository has just been put live, under a GPL license. :)
https://github.com/Automattic/gridicons/

🎉

@folletto folletto closed this as completed Mar 1, 2016
@afsheenirani
Copy link
Contributor Author

@folletto - Thanks for the quick turnaround...really appreciate it!

@afsheenirani
Copy link
Contributor Author

@folleto - I also don't see SocialLogo in the new repository. I'm guessing that is another repository as well. Any clue why they are kept separate?

@folletto
Copy link
Contributor

folletto commented Mar 2, 2016

Yes, unfortunately that's another one.

The reason it's separate it's because social logos are third party logos, not something we design, and are added in different ways. Sorry about that.

@jasmussen
Copy link
Member

The Social Logos repo is also GPL, though! https://github.com/Automattic/social-logos

@afsheenirani
Copy link
Contributor Author

Thanks @folletto and @jasmussen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants