-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts / Pages: search does not clear when switching sites #453
Comments
Fixes #453. When site was switched, component detected no change so Did not do search again.
Previously new search was triggered only when search term changed Now it changes also when site is switched. Fixes #453.
Possibly related #1403 |
14Apr16 Bug Scrub Confirmed this is still an issue. Search for a post, switch sites to a 'recently open' site at the top of the Sites list, and the search field is still populated but not applied to the list of displayed posts. If the switched-to site is not in the 'recently open' section then the search is cleared. Tested using OSX Chrome v49 |
Still happening — same steps as above. To fix, could we always have search filter results if the search input field isn't empty? |
#1112 has related information on the technical side of a possible fix for this — global search state. |
#bug-scrub This is still an issue. In my testing, the search field never clears. Instead, the behavior is the same each time you switch sites: Search for a post, switch sites to another site, and the search field is still populated but not applied to the list of displayed posts. Each time you switch back or to another site you see the same behavior. |
Confirmed still an issue |
Usage notes shared via Matt M today:
|
Closing... |
Originally raised by @rralian:
If you switch sites while you have search open, the search field does not get cleared. However, the search is no longer active either. Either we should clear search upon switching sites or we should at least honor the search string when we switch to a new site. I'm leaning towards honoring the search string, as I can see a valid case of wanting to search for certain strings across several sites. i.e., "Hmmm... it's not in this site, maybe I posted that to this site?"
More feedback on this from @lancewillett
Steps taken (testing with Safari 8.0.8 on OS 10.10.5):
The text was updated successfully, but these errors were encountered: