Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts / Pages: search does not clear when switching sites #453

Closed
alisterscott opened this issue Nov 23, 2015 · 9 comments
Closed

Posts / Pages: search does not clear when switching sites #453

alisterscott opened this issue Nov 23, 2015 · 9 comments

Comments

@alisterscott
Copy link
Contributor

Originally raised by @rralian:

If you switch sites while you have search open, the search field does not get cleared. However, the search is no longer active either. Either we should clear search upon switching sites or we should at least honor the search string when we switch to a new site. I'm leaning towards honoring the search string, as I can see a valid case of wanting to search for certain strings across several sites. i.e., "Hmmm... it's not in this site, maybe I posted that to this site?"

More feedback on this from @lancewillett

  1. If you switch back to a previous a blog post search, the search string is still visible but not active, as Bob reported.
  2. If you switch to a new site (not previously viewed) — you will see a cleared search string and a closed search box.

Steps taken (testing with Safari 8.0.8 on OS 10.10.5):

  1. Go to My Sites
  2. Click on a site and click "Blog Posts"
  3. Click the search icon at top right to open search bar, type in "test", and hit Enter to search
  4. Click on "Switch Site" and pick a different site
  5. Click "Blog Posts" and note the search field is closed.
  6. Click the search icon at top right to open search bar, and notice the field is now empty. No "test" string in it.
@rralian rralian added this to the Core: Iteration 17 milestone Nov 30, 2015
@artpi artpi self-assigned this Dec 1, 2015
artpi added a commit that referenced this issue Dec 1, 2015
Fixes #453. When site was switched, component detected no change so
Did not do search again.
artpi added a commit that referenced this issue Dec 1, 2015
Previously new search was triggered only when search term changed
Now it changes also when site is switched. Fixes #453.
@lancewillett
Copy link
Contributor

Possibly related #1403

@hoverduck
Copy link
Contributor

14Apr16 Bug Scrub

Confirmed this is still an issue. Search for a post, switch sites to a 'recently open' site at the top of the Sites list, and the search field is still populated but not applied to the list of displayed posts. If the switched-to site is not in the 'recently open' section then the search is cleared.

Tested using OSX Chrome v49

@lancewillett
Copy link
Contributor

Still happening — same steps as above.

To fix, could we always have search filter results if the search input field isn't empty?

@lancewillett
Copy link
Contributor

#1112 has related information on the technical side of a possible fix for this — global search state.

@hoverduck
Copy link
Contributor

#bug-scrub

This is still an issue, but with a different signature. Now when switching between sites the search field remains open, but is unpopulated:

wp-calypso-453

@artpi artpi removed their assignment Oct 19, 2016
@rachelmcr
Copy link
Member

#bug-scrub

This is still an issue. In my testing, the search field never clears. Instead, the behavior is the same each time you switch sites: Search for a post, switch sites to another site, and the search field is still populated but not applied to the list of displayed posts. Each time you switch back or to another site you see the same behavior.

@alisterscott
Copy link
Contributor Author

Confirmed still an issue

@apeatling apeatling added this to the Product Quality milestone Jan 31, 2018
@apeatling apeatling removed this from the Product Quality milestone Jan 31, 2018
@lancewillett
Copy link
Contributor

Usage notes shared via Matt M today:

I was writing a bunch of new sub-pages
The search I put into the page list persists even when I click "Add another page" after publishing

@cathymcbride
Copy link
Contributor

Closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants