Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notices: switch to Gridicons #145

Closed
hoverduck opened this issue Nov 18, 2015 · 1 comment
Closed

Notices: switch to Gridicons #145

hoverduck opened this issue Nov 18, 2015 · 1 comment

Comments

@hoverduck
Copy link
Contributor

I've already swapped the dismiss 'X' and the arrow-link arrow for gridicons. In order to swap out the type (success, error, warning, info (and any others we want to add like update)) icon we need to add a switch or case statement to notices/notice.jsx that spits out the correct type into the Gridicon component. Right now we just use a before element styled off of a .is-type wrapping class, which will no longer do.

Currently w/ nasty noticons:
image

@hoverduck hoverduck added this to the Patterns: switch to gridicons milestone Nov 18, 2015
@rickybanister
Copy link

@mtias tackled this in #1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants