Add wp_localization_parser crate to make parsing accessible from other crates
#640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
change-message-bundle-args-value-type-to-FluentValue
to
trunk
March 26, 2025 23:38
oguzkocer
force-pushed
the
wp_localization_parser
branch
from
8637dab to
879a908
Compare
crazytonyli
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing logic will be used in #575, so it needs to be accessible outside of the proc macro crate.
This PR only moves the existing code without any functional changes. The only minor change is that
parsefunction now returns aResultjust so we can avoid unwrapping it in a library crate. The error type that's used is pretty basic at the moment, but we might end up adding more information as we build on our tooling.I also removed the
wp_messages::bindingsmod because the module separation is no longer useful.