Disable incompatible payment methods when manual capture is enabled #9470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
…patibility status
mdmoore
requested review from
a team and
danielmx-dev
and removed request for
a team
danielmx-dev
approved these changes
Sep 23, 2024
| @@ -603,6 +603,10 @@ private function update_enabled_payment_methods( WP_REST_Request $request ) { | |||
| $payment_method_ids_to_enable = $request->get_param( 'enabled_payment_method_ids' ); | |||
| $available_payment_methods = $this->wcpay_gateway->get_upe_available_payment_methods(); | |||
|
|
|||
| if ( $request->has_param( 'is_manual_capture_enabled' ) && $request->get_param( 'is_manual_capture_enabled' ) ) { | |||
| $payment_method_ids_to_enable = array_intersect( $payment_method_ids_to_enable, [ 'card', 'link' ] ); | |||
There was a problem hiding this comment.
A comment explaining why this is done and why are those payments methods selected would be helpful.
Or maybe just adding the array as a constant in Payment_Method with a descriptive name could be enough.
| $filtered_payment_methods = array_filter( | ||
| $enabled_payment_methods, | ||
| function ( $method ) { | ||
| return in_array( $method, [ 'card', 'link' ], true ); |
There was a problem hiding this comment.
As mentioned in another file, should a constant be defined for this array ?
|
|
||
| foreach ( $this->all_registered_gateways as $gateway ) { | ||
| $stripe_id = $gateway->get_stripe_id(); | ||
| if ( 'card' !== $stripe_id && 'link' !== $stripe_id ) { |
There was a problem hiding this comment.
Should the constants be used here?
|
Thanks for the suggestions @danielmx-dev. Rather adding a new constant just for manual capture payment methods, I've used used the constants already in place and added a comment. Let me know if that sounds alright with you. |
danielmx-dev
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9363
Changes proposed in this Pull Request
The goal of this change is to prevent payment methods which are not displayed on checkout from causing incompatibility notices in the checkout block. A couple different things lead to this problem:
Auth + Capture
When manual capture is enabled, LPMs that were already enabled remain enabled even though they're hidden from checkout. This leads to notices about incompatibilities in the checkout block.
A couple solutions were considered:
registerPaymentMethod().I've went with the second solution. Since these payment methods shouldn't appear on checkout or in the editor, they should be disabled. To do this, I've tapped into the save settings call which updates the enabled payment methods and disables any incompatible payment methods which were previously enabled. The only payment methods compatible with manual capture are
cardandlink.Inactive payment methods
Payment methods have a capability status, i.e.
active,inactive,pending, orunrequested. This status isn't taken into account when payment methods are being enabled. All non-activestatus payment methods are hidden from checkout, yet the gateway is still enabled and the payment method id is added to the list of enabled payment methods -upe_enabled_payment_method_ids. The solution here is to only enable payment methods that have theactivestatus.Testing instructions
Auth + Capture
upe_enabled_payment_method_idsoption ( easy to view via Dev Tools ).Inactive payment methods
This requires getting a payment method into a non-active status. The best way I've found to do this is by onboarding a new site.
rejectedand therefore not added toupe_enabled_payment_method_ids. Previously it would've been enabled.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge