Temporarily revert #9439 multi-currency v2 #9468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo
requested review from
a team and
cesarcosta99
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -643 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ricardo
changed the title
ricardo
requested review from
a team and
rafaelzaleski
and removed request for
cesarcosta99 and
a team
rafaelzaleski
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Looks good and tests well!
✅ Smoke test multi-currency.
✅ Ensure Disable save changes button unless settings have changed #9386 are still applied to the old code.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: p1726755214216999/1726688493.292339-slack-C01BZUL57SQ
TL;DR: We didn't find any regressions other than #9455, but we would like to postpone the release of it.
Fixes 233-gh-Automattic/woopayments
Changes proposed in this Pull Request
Reverts #9439 / af3cc60.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge