Fixes to enable using the new KYC for progressive onboarding. #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +97 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
…ommerce-payments into dev/9393-embedded-kyc-po
oaratovskyi
approved these changes
Sep 16, 2024
client/onboarding/kyc/index.tsx
Outdated
| { | ||
| source: source, | ||
| }, | ||
| 'WCPAY_ONBOARDING_KYC' |
There was a problem hiding this comment.
Noticed that getConnectUrl function arguments are the same for detailsSubmitted true and false cases
Probably a mistake here
There was a problem hiding this comment.
Whoops, sorry about that!
The intention here was to redirect to the Overview page if details are submitted (this is the case where a PO account has done initial KYC and go to the Connect page otherwise.
If the connect page will handle redirecting to the overview page in that case, this updated logic should work fine, but we should check it 🙂
There was a problem hiding this comment.
Thanks Dan, I'll check it 👍
There was a problem hiding this comment.
The intention here was to redirect to the Overview page if details are submitted (this is the case where a PO account has done initial KYC and go to the Connect page otherwise.
Oh hell... I assumed that getConnectUrl would retrieve the connect link provided through wcpaySettings.connectUrl but it doesn't; it provides the Connect page URL :(
We should try and use connect URLs (not Connect page URLs) - like here, and let the connect logic figure out where to point the user.
There was a problem hiding this comment.
@oaratovskyi @dmallory42 It will probably work in the current state also because we have logic to redirect from all the places :)
|
I've added the |
vladolaru
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9393
Changes proposed in this Pull Request
We use the same embedded KYC form to continue onboarding if the merchant drops off or needs to provide further business details (like with PO accounts).
Additionally, we record the
wcadmin_wcpay_onboarding_kyc_exitTracks event when merchants exit this embedded KYC, as opposed to the one in our MOX (that is recorded via thewcadmin_wcpay_onboarding_flow_exitedevent with thestep:embeddedprop).Testing instructions
Prerequisites
npm run listenon your local server. (if using local client)Embedded KYCis enabled in the Dev Tools (if you don't see it, update the dev tools to the latest version)Overviewpage, with the confetti and modal about receiving deposits appearing./payments/onboarding/kycpage, and you should be able to see thecollect_payout_requirementsin the search query on the URL.progressive_onboardingarray:npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge