Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate express payments buttonAttributes API from the Checkout Block #8888
Integrate express payments buttonAttributes API from the Checkout Block #8888
Changes from all commits
cb69a58
2586edb
6ebab87
c588fef
93a14bc
d0951e5
ca158f0
0ba5be0
de470e8
421ab6d
b917a9b
33b6eec
2abb118
578c9e6
8666f15
dcdb55c
b90b69a
7886e27
d647bd0
01c2795
6064546
7f623fe
49eaf8c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this generates an error locally, saying
wcpaySettings
isundefined
. Not quite sure where to go with it, seems like it should be exported as a global but it's not there 🤷There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm seeing the same thing. It started happening as soon as you added
getDefaultBorderRadius()
there in 2abb118 and I think it's uncovering a bad assumption from when we added the utility function.It seems
wcpaySettings
isn't always loaded (like we expected while adding support for ECE) but we never got an issue because the previous version ofgetExpressCheckoutButtonAppearance
never actually calledgetDefaultBorderRadius
. The border radius was always present onwcpayExpressCheckoutParams.button
.I pushed a fix for this in dcdb55c 👍