Fix security notices #8474
Merged
Fix security notices #8474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaeldcom
approved these changes
Mar 26, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
reykjalin
reviewed
Mar 26, 2024
Comment on lines
+1022
to
1025
| // No need to escape here as the function called handles it. | ||
| // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | ||
| echo \WC_Payments_Utils::esc_interpolated_html( | ||
| $message, |
There was a problem hiding this comment.
Hmm, I would've expected this to get caught because of the following lines in phpcs.xml.dist:
woocommerce-payments/phpcs.xml.dist
Lines 73 to 77 in 9b6a7da
I wonder if we're not adding that correctly 🤔
It'd be neat if we didn't need the ignore. I'll see if I can look into this as part of #8460 👍
There was a problem hiding this comment.
Thank you @reykjalin, good catch there and thanks for looking into it. I wasn't aware of that rule.
There was a problem hiding this comment.
Looks like this is actually an issue with the ruleset and not necessarily our config (although I think the config is wrong as well):
See WordPress/WordPress-Coding-Standards#1176 and WordPress/WordPress-Coding-Standards#2370.
I think the config is wrong based on this example.
Either way, I guess this can wait until the next time we update the PHPCS sniffs since all those issues and PRs are still open 🫠
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8468
Changes proposed in this Pull Request
Add escaping and ignore where needed.
Testing instructions
Make sure tests pass.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge