Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using E2E_RETRY_TIMES with woocommerce/e2e-environment v0.3.0 #4534

Closed
wants to merge 6 commits into from

Conversation

htdat
Copy link
Member

@htdat htdat commented Aug 4, 2022

Fixes #

Changes proposed in this Pull Request

Testing instructions


  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@htdat
Copy link
Member Author

htdat commented Aug 4, 2022

@htdat
Copy link
Member Author

htdat commented Aug 5, 2022

In-progress note:

It turns out it's not easy to just upgrade the woocommerce/e2e-environment package. I needed to do a few things

1, WC_E2E_FOLDER env var needs to be set. Otherwise, the new package will not pick up our tests/e2e/config/jest.setup.js file. This is helpful for Woo core because it’s now a monorepo, i.e. many projects in the same repo. Doc - code ref 1 and 2. However, it's not helpful for us. I think we can create a PR to set a default value for this var to an empty string.

2, Somehow, this issue happened jestjs/jest#9359, and I needed to move out setTestTimeouts functions. Otherwise, the timeout value is not properly set.

After this, this seems to run better https://github.com/Automattic/woocommerce-payments/runs/7687099406?check_suite_focus=true

@htdat htdat changed the title Try using E2E_RETRY_TIMES Try using E2E_RETRY_TIMES with woocommerce/e2e-environment v0.3.0 Aug 8, 2022
@htdat
Copy link
Member Author

htdat commented Aug 8, 2022

Closing this try PR.
p1659950516959449-slack-C01BPL3ALGP

@htdat htdat closed this Aug 8, 2022
@htdat htdat deleted the try/use-E2E_RETRY_TIMES branch September 7, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant