Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BNPL - Respect minimum order amounts when adding the PMME to the page #9244

Closed
mdmoore opened this issue Aug 9, 2024 · 3 comments · Fixed by #9355
Closed

BNPL - Respect minimum order amounts when adding the PMME to the page #9244

mdmoore opened this issue Aug 9, 2024 · 3 comments · Fixed by #9355
Assignees
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.

Comments

@mdmoore
Copy link
Member

mdmoore commented Aug 9, 2024

Describe the bug

BNPL has minimum order amounts. Stripe uses the total when determining which BNPL methods are applicable. If no payment methods are applicable, say due to the total not hitting the minimum, no payment methods are displayed. Until recently, this wasn't a problem because nothing would be displayed on the page. However, the container with id payment-method-message is still added to the page and contains an empty Stripe iframe. Since #9166, a skeleton loader is added. When minimum order amounts aren't hit, the skeleton loader still appears, but no PMME is displayed when loading is finished. The result is a loader that appears to load nothing.

To Reproduce

  1. Enable all BNPL payment methods
  2. Set your currency to USD
  3. Create a product that is less than $1.
  4. Navigate to the product and see the skeleton loader appear

Screenshots

Screen.Recording.2024-08-09.at.1.05.11.PM.mov

Expected behavior

The loader shouldn't appear if minimum order amounts aren't met for the selected currency.

@mdmoore mdmoore added type: bug The issue is a confirmed bug. focus: checkout payments labels Aug 9, 2024
@pierorocca pierorocca added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Aug 10, 2024
@bborman22
Copy link
Contributor

@rafaelzaleski
Copy link
Contributor

@cesarcosta99 @bborman22 While testing another issue, I noticed that this bug can also occur with the maximum amount, but I believe the fix only addressed the minimum amount. Notice the blank space in the image below.

Screen Shot 2024-09-10 at 11 15 21 AM

@cesarcosta99
Copy link
Contributor

While testing another issue, I noticed that this bug can also occur with the maximum amount, but I believe the fix only addressed the minimum amount. Notice the blank space in the image below.

Thanks for reporting this, Rafael. I created #9459 to track it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants