Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update node-fetch from 2.6.9 to 2.6.11 #1352

Merged
merged 2 commits into from
May 10, 2023
Merged

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented May 9, 2023

Description

This PR updates node-fetch from 2.6.9 to 2.6.11 and includes a bug fix for handling BOM in text and JSON responses.

Steps to Test

CI should pass.

@sjinks sjinks self-assigned this May 9, 2023
@sjinks
Copy link
Member Author

sjinks commented May 9, 2023

Fails with "networkError: ReferenceError: TextDecoder is not defined".

Pretty interesting, as TextDecoder should be available on the global object since Node 11.

@sjinks
Copy link
Member Author

sjinks commented May 9, 2023

It looks like this is going to be reverted: node-fetch/node-fetch#1741

Oh well.

@jimmywarting
Copy link

revert fixed

@sjinks sjinks changed the title chore(deps): Update node-fetch from 2.6.9 to 2.6.10 chore(deps): Update node-fetch from 2.6.9 to 2.6.11 May 10, 2023
@sjinks sjinks merged commit 16e80cc into develop May 10, 2023
@sjinks sjinks deleted the update/node-fetch branch May 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants