feat(dev-env)!: Replace MailHog with Mailpit #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjinks
force-pushed
the
replace-mailhog-with-mailpit
branch
from
f45a098
to
be4526a
Compare
sjinks
requested review from
rinatkhaziev,
pschoffer and
alecgeatches
and removed request for
rinatkhaziev
|
Another improvement is that Mailpit's image is much smaller than MailHog's: mailhog/mailhog:v1.0.1: 392MB |
|
|
pschoffer
approved these changes
Apr 11, 2023
| mailhog: | ||
| type: mailhog | ||
| <% if ( mailpit ) { %> | ||
| mailpit: |
There was a problem hiding this comment.
Nice I like that we have our custom service for this. Less magic is good.
|
As per this comment, now using |
|
This is how it looks after Automattic/vip-container-images#464 and Automattic/vip-container-images#465:
|
sjinks
force-pushed
the
replace-mailhog-with-mailpit
branch
from
8369958
to
ab71875
Compare
sjinks
force-pushed
the
replace-mailhog-with-mailpit
branch
from
ab71875
to
c0eff03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mailhog is not maintained anymore. Moreover, it has serious bugs that make it inconvenient to use:
Mailpit is a faster alternative to MailHog; it is recommended, for example, by Laravel.
This PR replaces MailHog with Mailpit, retaining backward compatibility. As a side effect, there is now one more Lando plugin that we can drop:
@lando/mailhog.Backward Compatibility
.lando.ymlis rebuilt automatically (because we removed@lando/mailhog).instance_data.json,mailhogis treated as a synonym tomailpit.--mailhogcommand line switch is aliased to--mailpit(and triggers a deprecation warning).Steps to Test
E2E tests should pass.