Try using AMP-based nav menu in non-AMP pages #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in ampproject/amphtml#15583 the AMP project plans to directly supporting the use of AMP components outside of AMP pages. In this way, the
amp-sidebarandamp-accordioncan be used as web components in a vanilla HTML pages, and there is no need maintain separate non-AMP implementations.In anticipation of this, this PR shows how it can be done. As can be seen in testing, it actually works fine. The only thing is that it is not officially supported yet, though support is improving this year.