Blockbase: Implement the Button elements API #6041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This hasn't been moved out of 'in progress' but I think it should be safe to merge into Blockbase (whenever, though I tagged it for inclusion in the 3.0 release). |
mikachan
approved these changes
Jun 9, 2022
|
We should make a quick test on dotcom but this should be mergeable now |
pbking
added a commit
that referenced
this pull request
Jul 20, 2022
Refactor/blockbase color admin (#6043) Moved templates from old folder location to new (#6073) Blockbase: Implement the Button elements API (#6041) Blockbase: Implement Comment Block and removed CSS (#6080) Fix/migrate blockbase font self hosted (#6123) Blockbase children: update comments block (#6153) Blockbase: Changed the trigger to render social icons (#6079) Blockbase: move button padding styles from ponyfill to theme.json (#5901) Co-authored-by: Grant Kinney <[email protected]> Co-authored-by: Jeremy Yip <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: madhusudhand <[email protected]>
Merged
|
Closing: Work merged in #6167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR adds the button element to theme.json so it can be accessed by plugins. It shouldn't affect how the buttons look before or after this PR, on Blockbase or any of its children. I will create a followup PR that removes the CSS that will no longer be needed after this is merged, but I'll keep that separated since it will require that the theme has the GB installed for it to work. We can wait to merge that change after it lands in core.