-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank Canvas Blocks: Add default styles for Verse block #3451
Conversation
@@ -168,6 +168,14 @@ | |||
"lineHeight": 1.125, | |||
"fontFamily": "var(--wp--preset--font-family--headings)" | |||
} | |||
}, | |||
"verse": { | |||
"padding": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this just be one variable instead of one each for top right bottom left?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of those being separate. I used WordPress/gutenberg#27579 as a reference.
This looks like a really easy one to do in Gutenberg. I was going to do it today until my environment broke... |
I've seen your PR: WordPress/gutenberg#27579 Do you think there's a chance it will get merged soon? |
I have made a much simpler version: WordPress/gutenberg#29820 Let's hope this one is quicker to merge... |
Cool - seems like your PR is going to get merged soon (if I understand the discussion correctly). I'm happy to close this for now. |
Part of #3413