Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Padding Control in Gutenberg #2449

Open
ianstewart opened this issue Sep 10, 2020 · 4 comments
Open

Add support for Padding Control in Gutenberg #2449

ianstewart opened this issue Sep 10, 2020 · 4 comments
Assignees

Comments

@ianstewart
Copy link
Contributor

Padding control for Group is on the way!

WordPress/gutenberg#24966

It looks like it requires theme support …

Enable the custom spacing support for your theme add_theme_support( 'experimental-custom-spacing' )

We usually run the latest version of Gutenberg on WP.com much earlier than core WordPress. Usually around 1 to 4 weeks after release.

Stubbing out an issue here to make sure we have this support in our Automattic Themes. As this may take a while I've made a list of what might be a priority order.

  • All new themes.
  • All Varia themes.
  • All popular themes.
  • All premium themes.
  • All themes.

Generally, I think it makes sense to have all new themes support all new features on a rolling basis as a first priority for Gutenberg support. Though saying that I don't mean to suggest that older themes shouldn't get support. Just that we should always have at least one theme on the edge or one iron in the fire for testing.

Currently, only Seedlet and Sidekick have this support.

@kjellr
Copy link
Contributor

kjellr commented Jan 26, 2021

Just noting that this is in Seedlet already:

// Add support for experimental cover block spacing.
add_theme_support( 'experimental-custom-spacing' );

... but that it doesn't appear to be working as of my testing today.

@scruffian
Copy link
Member

This has been done in Seedlet and Varia. I'll keep it open so we keep it in mind for other themes.

@danieldudzic
Copy link
Contributor

This doesn't seem to belong in the Maintenance queue. I'm removing it for now.

@jeffikus jeffikus added the [Type] Enhancement New feature or request label Jun 8, 2021
@jeffikus
Copy link
Contributor

@ianstewart is this still an issue? If not let's close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants