-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three Latest Podcast Episodes #140
Comments
|
Ah yes, it looks like TT1 is setting a negative margin on a full-width Group Block with background specifically. I'm going to try to find out if this was on purpose. What kind of issue would you raise for editor styles here? |
I updated the code and got rid of the spacer (using group padding instead). The issue with TT1 remains, but I think it looks ok in other themes: It's worth noting that if I enable end gutters on the Layout Grid block, it does have the spacing at the ends (smaller than in other themes that seem to be handling this differently). On the starter site it is set up without the end gutters tho, and I'm not sure of the significance of this. But if we enabled end gutters, this pattern looks acceptable in TT1 as well.
|
I'm really looking forward to something layout-grid-like in core. :) Let's proceed with this one. (Also, making sure that the updates are made on the starter site if they haven't been yet.) |
I added the end gutters and explicitly set text color. Publishing 🚀
|
Here's a screenshot from starter site running Spearhead:
The text was updated successfully, but these errors were encountered: