-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace profile header view with Compose UI #3235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiSikora
added
[Type] Tech Debt
Involving upgrades or refactoring to maintain or enhance the codebase.
do not merge
[Area] Compose
labels
Nov 15, 2024
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
MiSikora
force-pushed
the
task/profile-header-compose
branch
from
November 15, 2024 16:44
6f72eb9
to
c882fb5
Compare
geekygecko
approved these changes
Nov 18, 2024
modules/features/profile/src/main/java/au/com/shiftyjelly/pocketcasts/profile/ProfileHeader.kt
Outdated
Show resolved
Hide resolved
…etcasts/profile/ProfileHeader.kt Co-authored-by: Philip Simpson <[email protected]>
MiSikora
force-pushed
the
task/profile-header-compose
branch
from
November 18, 2024 08:26
e86b997
to
b469504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Area] Compose
[Type] Tech Debt
Involving upgrades or refactoring to maintain or enhance the codebase.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the header in the profile screen with Compose UI components. It includes minor changes, improvements, and some alignment with iOS:
The old view has not been removed as it is still used by the Automotive app. It is also inherited from and used in the Account Details screen.
Testing Instructions
Test profile header behavior in different scenarios:
Screenshots or Screencast
Comparison
Compose preview
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesAll strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...