Add grunt (WIP) #37
Merged
Add grunt (WIP) #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds jshint and phplint, as well as some i18n tools.
We can rely on Core's `$wp_locale` global for this info.
This function got redid in r100098-wpcom but the variable declarations from the old version stuck around. Tidy them up.
Setting up a timeout anonymous function that calls something else that's never re-called is overly complicated.
| var fragment = $( window.location.hash ); | ||
| // Scroll to the fragment identifer | ||
| setTimeout( function () { | ||
| var fragment = $( document.body).find( window.location.hash ); |
There was a problem hiding this comment.
Whitespace.
Looks good to me otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is doing a number of things: