Fix better asset routing #36
Merged
+117
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you installed O2 by downloading `o2-master.zip` and installed that zip file, it would go into `/wp-content/plugins/o2-master/o2.php` and such -- which this method of specifying the path to assets would fail on. By being more dynamic as to specifying what folder we're in, we'll be more reliable however we're used.
__DIR__ is PHP 5.3+ only, and will not function in PHP 5.2 Where possible, swap it out with a `O2__DIR__` constant for less code churn and easier discoverability later.
This will grant us greater flexibility if we want to move the class to a subfolder at some point.
This is for consistency with the coding styles in the rest of the project.
| @@ -17,7 +17,7 @@ static function should_load_ui( $load ) { | |||
| } | |||
|
|
|||
| static function enqueue_scripts() { | |||
| wp_enqueue_script( 'o2-suggestions', plugins_url( 'js/suggestions.js', __FILE__ ), array( 'jquery' ) ); | |||
| wp_enqueue_script( 'o2-suggestions', plugins_url( 'modules/suggestions/js/suggestions.js', , O2__FILE__ ), array( 'jquery' ) ); | |||
There was a problem hiding this comment.
I think you got a copy-paste typo with the commas here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves several issues with the plugin folder being extra fragile from potentially being misnamed from
o2to something else.Also adds some extra consistency within the project regarding the inclusion of files and adds some PHP 5.2 compat to boot by removing
__DIR__