-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NAN to v2 #580
Upgrade NAN to v2 #580
Conversation
Sorry, empty description meant to say: NAN v2 isn't released yet so this is a WIP, not intended to be merged. NAN v2 is a major rewrite that is forward compatible to V8 4.5 so it support io.js v3 which is in RC at the moment while we get NAN v2 out (because everything is broken thanks to V8 43 and 4.4). This version of NAN should also give us automatic support for Node.js v4 (most likely version, could be v5 though) when it comes out in a few months. I'll update here when NAN is released and this is ready to merge. There's currently a bug holding this up from passing all the tests and NAN v2 isn't in npm yet either. |
The |
There is no direct replacement. You could attach a node::Buffer or v8::TypedArray as a hidden property. Typed arrays won't work with v0.10 though, a Buffer is more portable. |
@bnoordhuis Though that would present a minor change in API, since the CanvasPixelArray is clamped, but Uint8Array is not. |
Good point. You'd have to use v8::Uint8ClampedArray in that case and guard with #ifdefs. |
OK, this is getting a bit out of hand for what I have time for so I'm going to have to put this on the backburner and ask that anyone here who wants node-canvas to work with io.js 3.0 and beyond (including the next Node) can pick up from this branch if they want and work with that. |
Looking forward |
this needs help from someone with the time to grok what's required in order to bring back the support that was lost with the removal of the relevant V8 APIs mentioned above |
It's being done. #604 |
Adding to the list: nodejs/node#2798. |
Superseded by another pull request that got merged |
For future reference, that PR was #622. |
Thank you 👍 |
No description provided.