-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nan #1944
Update nan #1944
Conversation
v14 requires 2.14.1. The semver range in package.json already allowed for that version, but this requires at least that version. None of the other changes (2.14.2, 2.15.0) matter for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Still getting Canvas.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::shared_ptr __c In both node 14 & 16 |
@omerts please open a new issue with more info, that's unrelated to this PR. |
Did a new issue get opened for this @omerts? I'm seeing this when building on master with electron 16.
I'm happy to pay/sponsor for this to get fixed. 💰 |
@semireg |
the same problem. |
v14 requires 2.14.1. The semver range in package.json already allowed for that version, but this requires at least that version.
None of the other changes (2.14.2, 2.15.0) matter for us.