Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nan #1944

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Update nan #1944

merged 2 commits into from
Dec 8, 2021

Conversation

zbjornson
Copy link
Collaborator

v14 requires 2.14.1. The semver range in package.json already allowed for that version, but this requires at least that version.

None of the other changes (2.14.2, 2.15.0) matter for us.

  • Have you updated CHANGELOG.md?

v14 requires 2.14.1. The semver range in package.json already allowed for that version, but this requires at least that version.

None of the other changes (2.14.2, 2.15.0) matter for us.
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zbjornson zbjornson merged commit aed721d into master Dec 8, 2021
@zbjornson zbjornson deleted the nan-2-15-0 branch December 8, 2021 18:52
@omerts
Copy link

omerts commented Jan 23, 2022

Still getting Canvas.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::shared_ptr __c

In both node 14 & 16

@zbjornson
Copy link
Collaborator Author

@omerts please open a new issue with more info, that's unrelated to this PR.

@semireg
Copy link

semireg commented Feb 15, 2022

Did a new issue get opened for this @omerts?

I'm seeing this when building on master with electron 16.

"...\app\node_modules\canvas\build\binding.sln" (default target) (1) ->
"...\app\node_modules\canvas\build\canvas-postbuild.vcxproj.metaproj" (default target) (2) ->
"...\app\node_modules\canvas\build\canvas.vcxproj" (default target) (3) ->
(Link target) ->
  Canvas.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::shared_ptr<class v8::BackingStore> __cdecl v8::ArrayBuffer::GetBackingStore(void)" (__imp_?GetBackingStore@ArrayBuffer@v
8@@QEAA?AV?$shared_ptr@VBackingStore@v8@@@std@@XZ) referenced in function "void __cdecl parsePNGArgs(class v8::Local<class v8::Value>,struct PngClosure &)" (?parsePNGArgs@@YAXV?$Local@VValue@v8@@@v8@@AEAUPngClosure@@@Z)
 [...\app\node_modules\canvas\build\canvas.vcxproj]
  CanvasRenderingContext2d.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: class std::shared_ptr<class v8::BackingStore> __cdecl v8::ArrayBuffer::GetBackingStore(void)" (__imp_?GetBackingS
tore@ArrayBuffer@v8@@QEAA?AV?$shared_ptr@VBackingStore@v8@@@std@@XZ) [...\app\node_modules\canvas\build\canvas.vcxproj]
  ImageData.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: class std::shared_ptr<class v8::BackingStore> __cdecl v8::ArrayBuffer::GetBackingStore(void)" (__imp_?GetBackingStore@ArrayBuffe
r@v8@@QEAA?AV?$shared_ptr@VBackingStore@v8@@@std@@XZ) [...\app\node_modules\canvas\build\canvas.vcxproj]
  ...\app\node_modules\canvas\build\Release\canvas.node : fatal error LNK1120: 1 unresolved externals [...\app\node_modules\canvas\build\
canvas.vcxproj]

I'm happy to pay/sponsor for this to get fixed. 💰

@woestler
Copy link

woestler commented Aug 1, 2022

@semireg
Hi, have you get this fixed ? I have the same problem. thanks.

@lqomg
Copy link

lqomg commented Nov 22, 2022

the same problem.

@Automattic Automattic locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants