feat(membership-plans): improvements #110
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,6 +66,7 @@ public static function init() { | |
| add_filter( 'post_row_actions', array( __CLASS__, 'post_row_actions' ), 99, 2 ); // After the Memberships plugin. | ||
| add_filter( 'map_meta_cap', array( __CLASS__, 'map_meta_cap' ), 20, 4 ); | ||
| add_filter( 'wc_memberships_rest_api_membership_plan_data', [ __CLASS__, 'add_data_to_membership_plan_response' ], 2, 3 ); | ||
| add_filter( 'woocommerce_rest_prepare_wc_user_membership', [ __CLASS__, 'add_data_to_wc_user_membership_response' ], 2, 3 ); | ||
| add_filter( 'request', [ __CLASS__, 'request_query' ] ); | ||
| add_action( 'pre_user_query', [ __CLASS__, 'pre_user_query' ] ); | ||
| add_action( 'admin_notices', [ __CLASS__, 'admin_notices' ] ); | ||
|
|
@@ -100,14 +101,45 @@ function ( $membership ) { | |
| */ | ||
| public static function add_data_to_membership_plan_response( $data, $plan, $request ) { | ||
| if ( $request && isset( $request->get_headers()['x_np_network_signature'] ) ) { | ||
| $data['active_memberships_count'] = $plan->get_memberships_count( 'active' ); | ||
| $network_pass_id = get_post_meta( $plan->id, self::NETWORK_ID_META_KEY, true ); | ||
| if ( $network_pass_id && $request->get_param( 'include_active_members_emails' ) ) { | ||
| $data['active_subscriptions_count'] = self::get_plan_related_active_subscriptions( $plan ); | ||
| $data['active_members_emails'] = array_values( array_unique( self::get_active_members_emails( $plan ) ) ); | ||
| } else { | ||
| $data['active_subscriptions_count'] = __( 'Only displayed for plans with a Network ID.', 'newspack-network' ); | ||
| } | ||
| } | ||
| return $data; | ||
| } | ||
|
|
||
| /** | ||
| * Get the active subscriptions related to a membership plan. | ||
| * | ||
| * @param \WC_Memberships_Membership_Plan $plan The membership plan. | ||
| */ | ||
| public static function get_plan_related_active_subscriptions( $plan ) { | ||
| $product_ids = $plan->get_product_ids(); | ||
| $subscriptions = wcs_get_subscriptions_for_product( $product_ids, 'ids', [ 'subscription_status' => 'active' ] ); | ||
| return count( $subscriptions ); | ||
| } | ||
|
|
||
| /** | ||
| * Filter user membership data from REST API. | ||
| * | ||
| * @param \WP_REST_Response $response the response object. | ||
| * @param null|\WP_Post $user the user membership post object. | ||
| * @param \WP_REST_Request $request the request object. | ||
| */ | ||
| public static function add_data_to_wc_user_membership_response( $response, $user, $request ) { | ||
| if ( $request && isset( $request->get_headers()['x_np_network_signature'] ) ) { | ||
| // Add network plan ID to the response. | ||
| $plan = wc_memberships_get_membership_plan( $response->data['plan_id'] ); | ||
|
Contributor
There was a problem hiding this comment. Looks like |
||
| $response->data['plan_network_id'] = get_post_meta( $plan->id, self::NETWORK_ID_META_KEY, true ); | ||
| } | ||
| return $response; | ||
| } | ||
|
|
||
| /** | ||
| * Adds a meta box to the membership plan edit screen. | ||
| */ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we sanitize these to address the
WordPress.Security.ValidatedSanitizedInput.InputNotSanitizedwarning?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in a4ab6df