-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add updated translation files #1486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working on my end—I didn't test exhaustively, but I see the front-end strings being translated...
Thanks @dkoo! 🙌 |
# [1.73.0-alpha.1](v1.72.0...v1.73.0-alpha.1) (2023-07-07) ### Features * add updated translation files ([#1486](#1486)) ([3a44410](3a44410)) * allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734)) * **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
🎉 This PR is included in version 1.73.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.73.0](v1.72.2...v1.73.0) (2023-07-17) ### Features * add updated translation files ([#1486](#1486)) ([3a44410](3a44410)) * allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734)) * **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
🎉 This PR is included in version 1.73.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR is a long-overdue update to the plugin's POT file, and the PO, MO and translation JSON files for the supported languages in the blocks.
See 1200550061930446-as-1204849686104010
How to test the changes in this Pull Request:
This PR adds a lot of new files (a new JSON file for each new JS file), but no additional translations. I think the best way to review is to review the changed code, and do a few spot checks with the blocks, but I'm also open to any other testing you can do!
master
.master
instead of how they look in the code -- especially on the front-end.Please ping me if I can help answer any questions, or verify any testing! This one is a bit of a monster; I don't think it's necessary to manually check every changed string, only verify that the odd one still works as expected.
Other information: