Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add updated translation files #1486

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR is a long-overdue update to the plugin's POT file, and the PO, MO and translation JSON files for the supported languages in the blocks.

See 1200550061930446-as-1204849686104010

How to test the changes in this Pull Request:

This PR adds a lot of new files (a new JSON file for each new JS file), but no additional translations. I think the best way to review is to review the changed code, and do a few spot checks with the blocks, but I'm also open to any other testing you can do!

  1. Apply the PR.
  2. Switch your test site to one of the languages that have been translated in the plugin (German (de_DE), Spanish (es_ES), Belgian French (fr_BE), or Portuguese (pt_PT)).
  3. Add a couple blocks to the editor to make sure they're getting translated. This will only be the case for some of the older blocks -- the newer ones haven't been translated at all yet -- and some strings will be missing. A good couple options are the Donate Block, and the Homepage Posts block.
  4. Publish your page, and view in the editor and on the front-end:
    • For the Donate block, all of the tabs and 'Donation Amount' should be translated; 'Your contribution...' and 'Donate Now' will not be due to limitations in pulling these strings from the block.json to translate. The upside is they can be translated by editing the block, and that this doesn't introduce a regression -- the translation already stopped working in master.
    • For the Homepage Post block, the byline string (by) should be translated, and the date should be automatically localized.
  5. Repeat this for at least one more language.
  6. Manually review changes in the PR. There are a LOT of additions that can be ignored -- the big one to check for is things that have been removed:
    • Some changes are expected -- some strings have changed, or have been removed outright (like the aformentioned 'Donate' ones).
    • In some cases, some strings appear to have been removed from the JSON files - a couple examples include the 'keywords', or the block description. If you manually check the block though, the translations still work -- one example is the Homepage Post block description in Belgian French. I'm not sure why this is happening but am more concerned that the translations continue to work as they do on master instead of how they look in the code -- especially on the front-end.

Please ping me if I can help answer any questions, or verify any testing! This one is a bit of a monster; I don't think it's necessary to manually check every changed string, only verify that the odd one still works as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working on my end—I didn't test exhaustively, but I see the front-end strings being translated...

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo! 🙌

@laurelfulford laurelfulford merged commit 3a44410 into master Jun 28, 2023
2 checks passed
@laurelfulford laurelfulford deleted the feat/update-pot-file branch June 28, 2023 21:21
matticbot pushed a commit that referenced this pull request Jul 7, 2023
# [1.73.0-alpha.1](v1.72.0...v1.73.0-alpha.1) (2023-07-07)

### Features

* add updated translation files ([#1486](#1486)) ([3a44410](3a44410))
* allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734))
* **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.73.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 17, 2023
# [1.73.0](v1.72.2...v1.73.0) (2023-07-17)

### Features

* add updated translation files ([#1486](#1486)) ([3a44410](3a44410))
* allow Homepage Posts and Carousel blocks to include subcategories ([#1482](#1482)) ([faa8734](faa8734))
* **modal-checkout:** render order details under different conditions ([#1485](#1485)) ([ae62734](ae62734))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.73.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants