-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented getPopulatedDocs() #9766
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0a25640
chore: release 5.11.10
vkarpov15 ec5c540
feat: implemented getPopulatedDocs()
IslandRhythms 2990fb6
fix: edited formatting of document..test.js and document.js
IslandRhythms f81e95b
fix: changed const result = [] to let result = []
IslandRhythms 88616e4
fix: re-edited formatting
IslandRhythms 5c6993f
fix: edited formatting
IslandRhythms 5e8e7f7
feat: implemented getPopulatedDocs()
IslandRhythms 9a102d1
feat: added $getPopulatedDocs to index.d.ts
IslandRhythms 485c910
fix: added space to fix linter error
IslandRhythms c8a422d
chore: couple quick style fixes
vkarpov15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"name": "mongoose", | ||
"description": "Mongoose MongoDB ODM", | ||
"version": "5.11.9", | ||
"version": "5.11.10", | ||
"author": "Guillermo Rauch <[email protected]>", | ||
"keywords": [ | ||
"mongodb", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9834,4 +9834,35 @@ describe('document', function() { | |
assert.equal(fromDb.arr[0].abc, 'ghi'); | ||
}); | ||
}); | ||
|
||
it('supports getting a list of populated docs (gh-9702)', function() { | ||
const Child = db.model('Child', Schema({ name: String })); | ||
const Parent = db.model('Parent', { | ||
children: [{ type: ObjectId, ref: 'Child' }], | ||
child: { type: ObjectId, ref: 'Child' } | ||
}); | ||
|
||
return co(function*() { | ||
const c = yield Child.create({ name: 'test' }); | ||
yield Parent.create({ | ||
children: [c._id], | ||
child: c._id | ||
}); | ||
|
||
const p = yield Parent.findOne().populate('children child'); | ||
|
||
p.children; // [{ _id: '...', name: 'test' }] | ||
|
||
assert.equal(p.$getPopulatedDocs().length, 2); | ||
assert.equal(p.$getPopulatedDocs()[0], p.children[0]); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's also add a test that |
||
assert.equal(p.$getPopulatedDocs()[0].name, 'test'); | ||
}); | ||
}); | ||
|
||
}); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove the trailing whitespace |
||
|
||
|
||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not a fan of this name. Let's just use
keys