Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add splice() to DocumentArray to allow adding partial objects with splice() #15085

Merged
merged 1 commit into from
Dec 11, 2024
Merged

types: add splice() to DocumentArray to allow adding partial objects with splice() #15085

merged 1 commit into from
Dec 11, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #15041

Summary

We need splice() in the DocumentArray type definition, because splice(1, 0, { name: 'foo' }) should work.

Examples

@vkarpov15 vkarpov15 mentioned this pull request Dec 10, 2024
Closed
1 task
@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Dec 11, 2024
@vkarpov15 vkarpov15 added this to the 8.9 milestone Dec 11, 2024
@vkarpov15 vkarpov15 merged commit 891931b into master Dec 11, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-15041 branch December 11, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
8.9
Development

Successfully merging this pull request may close these issues.

Challenges with working on embedded arrays and typing issues
2 participants
@vkarpov15 @hasezoey