Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark documents that are populated using hydratedPopulatedDocs option as populated in top-level doc #15080

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #15048

Summary

#15048 points out that hydratedPopulatedDocs option for hydrate() doesn't mark the paths as populated(). Also turns out that hydrate() doesn't actually hydrate the nested populated docs.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/model.hydrate.test.js Show resolved Hide resolved
lib/document.js Show resolved Hide resolved
@vkarpov15 vkarpov15 added this to the 8.9 milestone Dec 11, 2024
@vkarpov15 vkarpov15 merged commit 36fb91a into master Dec 11, 2024
74 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-15048 branch December 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydrate populated fields not mark them as populated in the document
2 participants