fix(populate): fix a couple of other places where we get the document's _id with getters #14833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Aug 28, 2024
…ng schemas to avoid modifying original obj Fix #14827
|
I also accidentally pushed the fix for #14821 into this branch, so I will merge those two together |
2 tasks
This was referenced Sep 19, 2024
This was referenced Sep 19, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14827
Re: #14759
Summary
There are a few spots we missed in #14760 where
populate()logic getsdoc._id(which applies getters) instead ofdoc._doc._id(which skips getters)Examples