Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support schema type inference based on schema options timestamps as well #14773

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ark23CIS
Copy link
Contributor

@ark23CIS ark23CIS commented Aug 1, 2024

support schema type inference based on schema options timestamps as well

Fix #13215

Summary
Currently, InferSchemaType and InferRawDocType does not infer type based on timestamps fields provided in the schema options, which can lead to some difficulties while developing process (you'll have to add fields into your schema types manually to avoid the issue or extend returned typescript type).

@ark23CIS ark23CIS force-pushed the ark23cis/gh-13215 branch 5 times, most recently from ab056e6 to 5dd4064 Compare August 1, 2024 18:51
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 8.5.3 milestone Aug 7, 2024
@vkarpov15 vkarpov15 merged commit f356452 into Automattic:master Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document does not type non-default timestamp property names
2 participants