Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(connection): make transaction() return type match the executor function #14661

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14656

Summary

In MongoDB driver 6.x, withTransaction() now returns the executor function's return value. Mongoose should match that change.

Examples

@vkarpov15 vkarpov15 added this to the 8.5 milestone Jun 10, 2024
test/types/connection.test.ts Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 changed the base branch from master to 8.5 June 11, 2024 21:48
@vkarpov15 vkarpov15 merged commit 90fa8af into 8.5 Jun 11, 2024
27 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14656 branch June 12, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The return type of connection.tranaction method should not be Promise<void>.
3 participants