No global plugins applied when using mergePlugins on discriminators

[hasezoey]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the issue has not already been raised

Issue

(Continuation of #12604)

Since #12613 introduced a way to turn off the "overwrite of the plugins from the base schema", but now i noticed that no global plugins (mongoose._applyPlugins) are applied, which does not make the schemas the same as when calling with mongoose.model.

mongoose/lib/index.js

Lines 570 to 575 in c77dd1b

	if (schema) {
	if (_mongoose.get('cloneSchemas')) {
	schema = schema.clone();
	}
	_mongoose._applyPlugins(schema);
	}

---

Test Code and Output

Reproduction Repository / Branch: https://github.com/typegoose/typegoose-testing/tree/testHooks672

// NodeJS: 18.10.0
// MongoDB: 5.0 (Docker)
// Typescript 4.8.4
import * as mongoose from 'mongoose'; // [email protected]

const eventSchema = new mongoose.Schema(
  {
    time: Date,
  },
  { discriminatorKey: 'kind' }
);
eventSchema.pre('validate', function testv() {
  console.log('validate', this.constructor.name, this.modelName);
});

const clickedLinkEvent = eventSchema.clone();
clickedLinkEvent.add({ url: String });

const signedUpEvent = eventSchema.clone();
signedUpEvent.add({ user: String });

console.log('TEST0', (eventSchema as any).s.hooks._pres);

const EventModel = mongoose.model('Event', eventSchema);
const ClickedLinkEventModel = EventModel.discriminator('ClickedLinkEvent', clickedLinkEvent, { mergeHooks: false, mergePlugins: false });

(async () => {
  await mongoose.connect(`mongodb://localhost:27017/`, {
    dbName: 'verifyMASTER',
  });

  const events = await Promise.all([
    EventModel.create({ time: new Date(Date.now()), url: 'google.com' }),
    ClickedLinkEventModel.create({ time: Date.now(), url: 'google.com' }),
  ]);

  console.log('TEST1', (EventModel.schema as any).s.hooks._pres);
  console.log('TEST2', (ClickedLinkEventModel.schema as any).s.hooks._pres);

  await mongoose.disconnect();
})();

Output with mergeHooks: true or mergePlugins: true:

TEST0 Map(1) { 'validate' => [ { fn: [Function: testv], isAsync: false } ] }
validate model undefined
validate model undefined
TEST1 Map(3) {
  'validate' => [ { fn: [Function: testv], isAsync: false } ],
  'save' => [
    { fn: [Function: validateBeforeSave], isAsync: false },
    { fn: [Function: saveSubdocsPreSave], isAsync: false },
    { fn: [Function: shardingPluginPreSave], isAsync: false },
    { fn: [Function: trackTransactionPreSave], isAsync: false }
  ],
  'remove' => [
    { fn: [Function: removeSubDocsPreRemove], isAsync: false },
    { fn: [Function: shardingPluginPreRemove], isAsync: false }
  ]
}
TEST2 Map(3) {
  'validate' => [ { fn: [Function: testv], isAsync: false }, numAsync: 0 ],
  'save' => [
    { fn: [Function: validateBeforeSave], isAsync: false },
    { fn: [Function: saveSubdocsPreSave], isAsync: false },
    { fn: [Function: shardingPluginPreSave], isAsync: false },
    { fn: [Function: trackTransactionPreSave], isAsync: false },
    numAsync: undefined
  ],
  'remove' => [
    { fn: [Function: removeSubDocsPreRemove], isAsync: false },
    { fn: [Function: shardingPluginPreRemove], isAsync: false },
    numAsync: undefined
  ]
}

Output with mergeHooks: false or mergePlugins: false:

TEST0 Map(1) { 'validate' => [ { fn: [Function: testv], isAsync: false } ] }
validate model undefined
TEST1 Map(3) {
  'validate' => [ { fn: [Function: testv], isAsync: false } ],
  'save' => [
    { fn: [Function: validateBeforeSave], isAsync: false },
    { fn: [Function: saveSubdocsPreSave], isAsync: false },
    { fn: [Function: shardingPluginPreSave], isAsync: false },
    { fn: [Function: trackTransactionPreSave], isAsync: false }
  ],
  'remove' => [
    { fn: [Function: removeSubDocsPreRemove], isAsync: false },
    { fn: [Function: shardingPluginPreRemove], isAsync: false }
  ]
}
TEST2 Map(1) {
  'validate' => [ { fn: [Function: testv], isAsync: false }, numAsync: undefined ]
}

---

Workaround is to add mongoose._applyPlugins(discriminatorSchema) before calling from.discriminator, like:

mongoose._applyPlugins(clickedLinkEvent);
const ClickedLinkEventModel = EventModel.discriminator('ClickedLinkEvent', clickedLinkEvent, { mergeHooks: false, mergePlugins: false });

I opened this as "Other" with "discussion", because i am not sure if this wanted to be implemented as a "else" case of mergeHooks / mergePlugins, or as a options or at all.

---

PS: there also seems to be something wrong with this.modelName and this.constructor.name in the validate hook or the types are wrong and this is not actually a full Document.