fix(document): allow new Model(doc) to set immutable properties whe…

…n doc is a mongoose document Fix #8642
Automattic · Mar 8, 2020 · dfe41e2 · dfe41e2
1 parent 7b0bd36
commit dfe41e2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/document.js b/lib/document.js
@@ -128,15 +128,16 @@ function Document(obj, fields, skipId, options) {
   }
 
   if (obj) {
-    if (obj instanceof Document) {
-      this.isNew = obj.isNew;
-    }
     // Skip set hooks
     if (this.$__original_set) {
       this.$__original_set(obj, undefined, true);
     } else {
       this.$set(obj, undefined, true);
     }
+
+    if (obj instanceof Document) {
+      this.isNew = obj.isNew;
+    }
   }
 
   // Function defaults get applied **after** setting initial values so they

diff --git a/test/document.test.js b/test/document.test.js
@@ -8829,4 +8829,15 @@ describe('document', function() {
       assert.ok(!err.errors['nested.age']);
     });
   });
+
+  it('copies immutable fields when constructing new doc from old doc (gh-8642)', function() {
+    const schema = Schema({ name: { type: String, immutable: true } });
+    const Model = db.model('Test', schema);
+
+    const doc = new Model({ name: 'test' });
+    doc.isNew = false;
+
+    const newDoc = new Model(doc);
+    assert.equal(newDoc.name, 'test');
+  });
 });