made requested fixes

Automattic · Jun 14, 2023 · 9e08552 · 9e08552
1 parent 97dec73
commit 9e08552
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -719,12 +719,10 @@ Model.prototype.$__delta = function() {
   const optimisticConcurrency = this.$__schema.options.optimisticConcurrency;
   if (optimisticConcurrency) {
     if (Array.isArray(optimisticConcurrency)) {
+      const optCon = new Set(optimisticConcurrency);
       const modPaths = this.modifiedPaths();
-      for(let i = 0; i < modPaths.length; i++) {
-        if (modPaths.includes(optimisticConcurrency[i])) {
-          this.$__.version = dirty.length ? VERSION_ALL : VERSION_WHERE;
-          break;
-        }
+      if (modPaths.find(path => optCon.has(path))) {
+        this.$__.version = dirty.length ? VERSION_ALL : VERSION_WHERE;
       }
     } else {
       this.$__.version = dirty.length ? VERSION_ALL : VERSION_WHERE;

diff --git a/test/versioning.test.js b/test/versioning.test.js
@@ -526,7 +526,7 @@ describe('versioning', function() {
     assert.equal(thing_1.__v, 1);
     thing_2.set({ price: 1, name: 'Test' });
     const err = await thing_2.save().then(() => null, err => err);
-    assert.ok(!err)
+    assert.ok(!err);
   });
 
   it('gh-1898', async function() {