Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 5.2 compilation based on Gutenberg repo. #8018

Merged
merged 14 commits into from
Oct 23, 2017
Merged

Add PHP 5.2 compilation based on Gutenberg repo. #8018

merged 14 commits into from
Oct 23, 2017

Conversation

zinigor
Copy link
Member

@zinigor zinigor commented Oct 19, 2017

Using phpbrew we can build PHP 5.2 to test Jetpack in Travis CI on the lowest supported PHP version, based on this PR: WordPress/gutenberg#2049

@zinigor zinigor requested a review from a team as a code owner October 19, 2017 08:59
@zinigor zinigor mentioned this pull request Oct 19, 2017
Closed
@zinigor zinigor added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Oct 19, 2017
@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 23, 2017
@oskosk oskosk merged commit bb7f6c3 into master Oct 23, 2017
@oskosk oskosk removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 23, 2017
@jeherve jeherve deleted the add/php-52 branch October 24, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees
No one assigned
Labels
General Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zinigor @dereksmart @oskosk @notnownikki