[enejb]

Fixes #

Proposed changes

Split out of #53685, the exploration that runs the shared Protect dashboard without the Jetpack plugin. This PR only adds the package and moves the Jetpack plugin onto it. Behaviour is unchanged, except for the two points under "Behaviour changes" below.

• Add a new automattic/jetpack-monitor package with Automattic\Jetpack\Monitor\Monitor. It holds what modules/monitor.php did:
  • keeping each user's Downtime Monitor email choice in step with WordPress.com (jetpack.monitor.setNotifications / isUserInNotifications), with a local copy in monitor_receive_notifications<user_id>;
  • subscribing the user who turns the module on;
  • deleting the saved choice when a user unlinks or is deleted, or when the site disconnects;
  • fetching the last downtime.
• Monitor::init() also adds monitor to jetpack_get_available_standalone_modules, so a plugin other than Jetpack (such as Protect, in Protect: Run the shared Protect dashboard without the Jetpack plugin #53685) can switch the module on.
• Jetpack_Monitor in the Jetpack plugin becomes a shim: it calls Monitor::init() and every method forwards to the package, so existing callers (the REST settings endpoint, Abilities) keep working.
• set_notifications() returns true|WP_Error instead of dying. The shim still wp_die()s where the module used to.
• Add tests for the package.

Behaviour changes

• Turning the module on no longer wp_die()s when WordPress.com rejects the subscription. The module turns on, no local copy is saved, and the next settings read asks WordPress.com.
• The hooks are registered once, however many times Jetpack_Monitor is constructed. The REST endpoints construct it again, and on trunk each construction added a second set of callbacks.

Follow-up

• Monitor_Abilities still makes its own setNotifications, isUserInNotifications and getLastDowntime calls. Moving it onto the package is left for a separate PR.

The mirror repo Automattic/jetpack-monitor is set up, with trunk holding only composer.json, the API_TOKEN_GITHUB secret for autotagger, and the Packagist package.

Related product discussion/links

• Protect: Run the shared Protect dashboard without the Jetpack plugin #53685 (exploration this is split from)
• Protect Dashboard: Add a feature-flagged module that takes over the Protect page #53182, Protect Dashboard: Add the Scan section #53195 (shared Protect dashboard)

Does this pull request change what data or activity we track or use?

No. The same XML-RPC calls and options are used as before.

Testing instructions

On a site running this branch of the Jetpack plugin, connected, with your user linked to WordPress.com:

• Go to Jetpack › Settings › Security and turn on Downtime monitoring.
  • It turns on, and wp option get monitor_receive_notifications<your user id> returns 1.
• Turn Get alerts if your site goes offline off and on again. Both saves succeed, and the option follows the toggle (0 / 1).
• Reload the page. The toggle keeps its state.
• Disconnect your user from WordPress.com (Jetpack › Dashboard › Connection), or disconnect the site.
  • monitor_receive_notifications<your user id> is deleted.
• Check the PHP error log for errors mentioning Monitor.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/monitor-package branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/monitor-package

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/monitor-package

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/modules/monitor.php	8/21 (38.10%)	-13.02%	-9 💚

1 file is newly checked for coverage.

File	Coverage
projects/packages/monitor/src/class-monitor.php	20/33 (60.61%) 💚

Full summary · PHP report · JS report

[kraftbj]

Three small things inline.

Separately, nothing in the package checks that init() wires up the activation and unlink/disconnect hooks. The plugin's REST tests cover that through the shim today, but once Protect calls Monitor::init() directly (PR 53685), nothing will. Could the package get a test for that, plus one for activation still succeeding when WordPress.com rejects the subscription?

[enejb]

Thanks! Added both in ccb2805:

• test_init_wires_the_hooks checks that init() registers the standalone-module filter and the activation, unlink, user-delete and disconnect hooks.
• test_activation_subscribes_the_user_without_failing_on_rejection fires jetpack_activate_module_monitor. When WordPress.com accepts, the choice is saved. When it rejects, activation still finishes and nothing is saved.

I mutation-checked both: dropping a hook from init(), failing activation on rejection, and skipping the subscription each fail exactly one test.

[kraftbj]

Approving. One non-blocking note inline.

[kraftbj]

Not blocking. This holds only when the user has no saved copy yet. Deactivating doesn't delete it, so if Monitor is turned off and back on while WordPress.com rejects the call, the user keeps whatever they had before, with no error. (Trunk leaves the same stale value, but at least the wp_die() surfaced it.) Deleting the copy on failure would make the comment true:

if ( is_wp_error( self::set_notifications( true ) ) ) {
	self::delete_notifications_copy( get_current_user_id() );
}