Repository navigation
Storybook: Use the modern admin color scheme (blueberry) by default #52849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adamwoodnz
merged 5 commits into
trunk
from
charts-285-charts-storybook-does-not-use-the-modern-wp-color-scheme
Sep 29, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dc5d5bf
Storybook: Default the admin theme color to blueberry
adamwoodnz 5687e40
Storybook: Add changelog entry for the admin color fix
adamwoodnz b2e5ab6
Address review: Note that the admin color override must follow the im…
adamwoodnz 6c6d70d
Charts: Correct Storybook comments about the default admin color
adamwoodnz 476e991
Address review: Link the upstream fix for the admin color override
adamwoodnz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
...ages/charts/changelog/charts-285-charts-storybook-does-not-use-the-modern-wp-color-scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Significance: patch | ||
| Type: changed | ||
| Comment: Correct Storybook comments about the default admin color scheme. | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...s/storybook/changelog/charts-285-charts-storybook-does-not-use-the-modern-wp-color-scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: fixed | ||
|
|
||
| Use the modern WordPress admin color scheme (blueberry) as the default admin theme color in stories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,19 @@ | ||
| // Root variables from js-packages base styles | ||
| @use "../../base-styles/root-variables"; | ||
| @use "@wordpress/base-styles/mixins"; | ||
|
|
||
| // @wordpress package styles | ||
| @import "@wordpress/components/build-style/style.css"; | ||
| @import "@wordpress/block-editor/build-style/style.css"; | ||
| @import "@wordpress/block-library/build-style/style.css"; | ||
| @import "@wordpress/block-library/build-style/theme.css"; | ||
| @import "@wordpress/block-library/build-style/editor.css"; | ||
|
|
||
| // block-editor and block-library reset the admin color to the legacy #007cba. | ||
| // Keep this after the imports: equal specificity, so source order decides. | ||
| // Remove once @wordpress/base-styles ships the modern default: | ||
| // https://github.com/WordPress/gutenberg/pull/83749 | ||
| :root { | ||
|
|
||
| @include mixins.admin-scheme(#3858e9); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're adding an override, we should probably add to the comment that this can be removed when the libraries are updated to the modern default (and bonus if it includes a link to the upstream PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, done in 476e991. The comment now says to remove the override once
@wordpress/base-stylesships the modern default, and links the upstream PR.No upstream ticket existed, so I opened WordPress/gutenberg#83748 and a draft fix, WordPress/gutenberg#83749. The legacy blue comes from
base-styles/_default-custom-properties.scss, which still setsadmin-scheme(#007cba)on:root.block-library,block-editorand most other packages include it. Only@wordpress/componentsmoved to#3858e9(WordPress/gutenberg#50193), and WordPress 7.0 then made Modern the core default (Trac #64546) without anyone updating the shared default.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!